Thanks to visit codestin.com
Credit goes to github.com

Skip to content

@ewels implementation of nf-core/tools#936 #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ewels wants to merge 10 commits into from
Closed

@ewels implementation of nf-core/tools#936 #943

ewels wants to merge 10 commits into from

Conversation

@ewels
Copy link
Member

@ewels ewels commented Mar 22, 2021

My version of #936 - have a look @KevinMenden and see what you think.

Main differences:

  • No additional imports
  • Single copy code instead of triplicate
  • Handles UnicodeDecodeError and copies file instead of exiting with an error

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@ewels ewels requested a review from KevinMenden March 22, 2021 20:25
@codecov
Copy link

codecov bot commented Mar 22, 2021 •
edited
Loading

Codecov Report

Merging #943 (8cfcb81) into dev (153e5fa) will increase coverage by 0.05%.
The diff coverage is 94.11%.

❗ Current head 8cfcb81 differs from pull request most recent head 396ebc2. Consider uploading reports for the commit 396ebc2 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #943      +/-   ##
==========================================
+ Coverage   69.56%   69.61%   +0.05%     
==========================================
  Files          34       34              
  Lines        4173     4180       +7     
==========================================
+ Hits         2903     2910       +7     
  Misses       1270     1270
Impacted Files Coverage Δ
nf_core/lint/nextflow_config.py 69.62% <ø> (ø)
nf_core/create.py 93.13% <94.11%> (-0.55%) ⬇️
nf_core/__main__.py 61.58% <0.00%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 153e5fa...396ebc2. Read the comment docs.

@ewels ewels force-pushed the phil-reimplement-936 branch from 8cfcb81 to 396ebc2 Compare March 22, 2021 20:58
@ewels
Copy link
Member Author

ewels commented Mar 22, 2021

What the hell have I done here 🤦🏻

@ewels
Copy link
Member Author

ewels commented Mar 22, 2021

Ok I need to go sleep because I am doing super stupid stuff.

Pushed as a commit to #926 instead

@ewels ewels closed this Mar 22, 2021
@ewels ewels deleted the phil-reimplement-936 branch March 22, 2021 21:01
@KevinMenden
Copy link
Contributor

KevinMenden commented Mar 23, 2021

😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KevinMenden KevinMenden Awaiting requested review from KevinMenden

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ewels @KevinMenden