-
Notifications
You must be signed in to change notification settings - Fork 223
Interactive prompts for 'download' and 'launch' #1027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
cb06dc9
Added questionary select list for releases
ErikDanielsson 519dd18
Added confirmation prompt for image download and some docs
ErikDanielsson 77808a4
Added prompt for singularity caching (and 'negated' prompt for image …
ErikDanielsson f53b942
Added prompt for compression type
ErikDanielsson 958e95b
Added checking for 'export NXF_SINGULARITY_CACHEDIR' in bashrc
ErikDanielsson 897bae3
Added version selection list for launch
ErikDanielsson 89ff0ad
Added path prompt
ErikDanielsson bf4b64a
Changed to only prompt when options are not specified
ErikDanielsson 8a945e7
Clean up some unnecessary changes
ErikDanielsson d39e4eb
Merge branch 'master' into prompts
ewels ec7d486
Fix syntax error
ewels 115c112
Testing and refactoring
ewels 935b64e
Fix behaviour when pipeline name doesn't exist
ewels b41337d
Better cli styling
ewels 48f9146
Fast fail for non-existant repos
ewels 0fc0477
More testing - bugfix
ewels 59e0654
Clean up + finish refactor for --container instead of --singularity
ewels bb6b6d2
Fix Singularity installation check
ewels d9c7207
Fix / rewrite code for singularity cachedir prompts + bashrc addition
ewels 1c921d6
Restructure and reorganise prompts code
ewels 9f0fe81
Tweaks to log messages
ewels 24adc00
Use new rich console stderr argument, streamline imports
ewels fe77d55
Unsafe ask, colour select for releases / branches
ewels 3c80067
Write some help text for prompts
ewels f9c9fdc
Refactored code that gets branches and releases and hashes. Rewired s…
ewels 60c3730
Pipeline name should be full_name
ewels 9c17495
Update nf_core/launch.py
ewels 9796e69
Merge branch 'dev' of github.com:nf-core/tools into prompts
ewels 3d0d415
Just bold, not white on bold.
ewels 10ddb01
Removed more white bold, replaced with bold.
ewels 06265eb
Awesome questionary path auto-completion for singularity cachedir path
ewels c63487c
Refine cli flags, -c now for container instead of compress
ewels 0f2b8f4
Launch - sort releases by release date
ewels f7f3754
Merge branch 'master' into prompts
ewels f1999d4
Check if terminal is interactive before prompting for setting
ewels 683242d
Screen container names for dynamic {squiggly_brackets}
ewels 7b745b3
Push up minimum version of rich, louder colours
ewels b66961c
Bump rich minimum version again, as v1.10.0 fixed table style issue
ewels a0bc438
Fix pytests for download code
ewels bd8152b
Don't force interactive terminal on GitHub Actions for pytest
ewels 9bbdbe3
Different approach to try to avoid interactive prompt in tests
ewels 67ec08b
Refactor: Move bunch of prompt / lookup code into utils for reuse
ewels ed9dd62
Launch: Prompt for pipeline and release
ewels ea32219
Pull in updates, fix merge conflict
ewels 8d4fc0e
nf_core.utils.get_repo_releases_branches() - return pipeline name.
ewels 5478af8
Update pytests
ewels 73fe7f4
Download - update readme docs
ewels 205340b
Download docs - didn't compress
ewels 70eca94
Merge branch 'master' into prompts
ewels 19f2d5c
Address review comments for singularty cachedir prompt
ewels File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless we are planning to extend this choice list at some point, this could also just be flag instead of a prompt I think.
But also fine leaving it as a prompt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My preference would be to leave it as a prompt. One could make a semi-reasonable case for offering
downloadto pull e.g. docker images to the local instance.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I went back on forth on this. At the moment it is just a
--singularityflag. However, with the interactive prompts I would have needed to make it an on/off flag (--singularity--no-singularity). I don't love littering the cli with these, and figured that--container [str]was kind of more concise and had the added benefit of future-proofing.@phue - as the only CharlieCloud user I know, does that have a similar concept of pulling image files? Would it ever be useful to add CharlieCloud image downloads to the
nf-core downloadcommand for example?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And yes I also wondered about docker too @pontus 👍🏻