Bump node-version to 16 #1398
Merged
Bump node-version to 16 #1398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes markdown linting
Member
Author
|
Just realised that the website doesn't specify the version at all: https://github.com/nf-core/nf-co.re/blob/master/.github/workflows/markdown.yml Maybe that's the best approach here.. |
Contributor
|
Nope. Now also the website fails: https://github.com/mashehu/nf-co.re/runs/5106165522?check_suite_focus=true |
Member
Author
|
Seems ok with v2 of the get-node thing though right? |
Also revert auto-markdown fixing in template markdown files.
Member
Author
|
ok, bumped the install node version and stripped the pinned version. Hopefully this works... |
apeltzer
approved these changes
Feb 8, 2022
mashehu
approved these changes
Feb 8, 2022
This was referenced Feb 10, 2022
jfy133
added a commit
to nf-core/eager
that referenced
this pull request
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes markdown linting, which now requires at least node version 12.
Hopefully pushing to 16 gives us some future-proofing for a while.
PR checklist
CHANGELOG.mdis updateddocsis updated