Thanks to visit codestin.com
Credit goes to github.com

Skip to content

set conda.enabled=true for Conda #1952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pinin4fjords merged 2 commits into from
Oct 14, 2022
Merged

set conda.enabled=true for Conda #1952

pinin4fjords merged 2 commits into from
Oct 14, 2022

Conversation

@pinin4fjords
Copy link
Member

@pinin4fjords pinin4fjords commented Oct 14, 2022 •
edited
Loading

This is the extension of nf-core/modules#2306 requested by @jfy133 , to account for conda not being enabled by default with NXF 22.10, refer to that thread for discussion.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2022

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @pinin4fjords,

It looks like this pull-request is has been made against the nf-core/tools master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the nf-core/tools dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@pinin4fjords pinin4fjords changed the base branch from master to dev October 14, 2022 14:57
@codecov
Copy link

codecov bot commented Oct 14, 2022 •
edited
Loading

Codecov Report

Merging #1952 (d0e79cd) into dev (409a6db) will increase coverage by 0.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #1952      +/-   ##
==========================================
+ Coverage   61.10%   61.38%   +0.27%     
==========================================
  Files          37       37              
  Lines        4677     4677              
==========================================
+ Hits         2858     2871      +13     
+ Misses       1819     1806      -13
Impacted Files Coverage Δ
nf_core/modules/modules_repo.py 75.81% <0.00%> (+1.86%) ⬆️
nf_core/download.py 55.06% <0.00%> (+2.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pinin4fjords pinin4fjords merged commit 19e0373 into dev Oct 14, 2022
@pinin4fjords pinin4fjords deleted the set_conda_enabled branch October 14, 2022 15:09
@pinin4fjords pinin4fjords mentioned this pull request Oct 29, 2022
Merged
13 tasks
@drpatelh drpatelh mentioned this pull request Dec 13, 2022
Merged
@mirpedrol mirpedrol mentioned this pull request Dec 15, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamrtalbot adamrtalbot adamrtalbot approved these changes

@drpatelh drpatelh Awaiting requested review from drpatelh

@jfy133 jfy133 Awaiting requested review from jfy133

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pinin4fjords @adamrtalbot