Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@mirpedrol
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Merging #2049 (a5b5810) into dev (73f6b49) will increase coverage by 0.02%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##              dev    #2049      +/-   ##
==========================================
+ Coverage   67.58%   67.61%   +0.02%     
==========================================
  Files          43       43              
  Lines        5572     5580       +8     
==========================================
+ Hits         3766     3773       +7     
- Misses       1806     1807       +1     
Impacted Files Coverage Δ
nf_core/components/remove.py 86.30% <84.84%> (-0.47%) ⬇️
nf_core/components/install.py 88.81% <100.00%> (+0.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mashehu
Copy link
Contributor

mashehu commented Nov 25, 2022

Added some polish on the messaging and some more checks, good to go now for me. Or should we first merge #2042 and include that into this?

Co-authored-by: Matthias Hörtenhuber <[email protected]>
@mirpedrol mirpedrol marked this pull request as ready for review November 25, 2022 14:18
@mirpedrol mirpedrol merged commit cb21513 into nf-core:dev Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants