Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@mirpedrol
Copy link
Member

@mirpedrol mirpedrol commented Dec 1, 2022

Avoid double quotes when specifying tool container URLs.

Close #2084

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Merging #2085 (0de2066) into dev (2c8efb1) will increase coverage by 0.00%.
The diff coverage is 85.71%.

@@           Coverage Diff           @@
##              dev    #2085   +/-   ##
=======================================
  Coverage   67.84%   67.84%           
=======================================
  Files          43       43           
  Lines        5588     5592    +4     
=======================================
+ Hits         3791     3794    +3     
- Misses       1797     1798    +1     
Impacted Files Coverage Δ
nf_core/modules/lint/main_nf.py 64.63% <85.71%> (+0.16%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mirpedrol mirpedrol merged commit 8fadd99 into nf-core:dev Dec 1, 2022
@mirpedrol mirpedrol deleted the lint-container-quotes branch December 1, 2022 11:50
@ewels

This comment was marked as off-topic.

@ewels

This comment was marked as off-topic.

@ewels
Copy link
Member

ewels commented Dec 1, 2022

ok basically ignore all of my comments above sorry. I was talking nonsense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants