Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@mashehu
Copy link
Contributor

@mashehu mashehu commented Dec 1, 2022

Should resolve #2083. Not sure how to test it...

@mashehu mashehu requested a review from awgymer December 1, 2022 16:23
@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Merging #2090 (69cfe04) into dev (f0b6c48) will decrease coverage by 0.00%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##              dev    #2090      +/-   ##
==========================================
- Coverage   68.01%   68.01%   -0.01%     
==========================================
  Files          43       43              
  Lines        5625     5628       +3     
==========================================
+ Hits         3826     3828       +2     
- Misses       1799     1800       +1     
Impacted Files Coverage Δ
nf_core/__main__.py 58.65% <ø> (ø)
nf_core/subworkflows/test_yml_builder.py 15.16% <0.00%> (-0.13%) ⬇️
nf_core/modules/test_yml_builder.py 52.00% <75.00%> (+0.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@awgymer
Copy link
Contributor

awgymer commented Dec 1, 2022

Hmm I don't think the logic in this command is that solid.

I get the following in my custom repo:

CRITICAL Cannot find directory 'modules/genie/samtools/merge'. Should be TOOL/SUBTOOL or TOOL

The thing is samtools/merge exists on the remote but I removed it and haven't yet pushed that change to the remote.
It also doesn't see a new module I have created but not yet pushed as an option.
This command should (I think) only ever be run in an actual modules repo no? And typically when you are creating a new module and so it won't be in the remote?

So really I don't think it should be using the ModulesRepo at all? It should be deriving the available modules from the actual directory it is in?

@awgymer awgymer linked an issue Dec 2, 2022 that may be closed by this pull request
@mirpedrol
Copy link
Member

I have added a new branch on git-lab called org-path to test these things https://gitlab.com/nf-core/modules-test/-/tree/org-path

@awgymer
Copy link
Contributor

awgymer commented Dec 5, 2022

I have added a new branch on git-lab called org-path to test these things https://gitlab.com/nf-core/modules-test/-/tree/org-path

Do we need to change the tests in this branch or has a PR been made separately which uses that branch for tests in tools?

@mashehu
Copy link
Contributor Author

mashehu commented Dec 5, 2022

we can start in this PR and then migrate some of the other remote-url tests for the other commands in separate PR(s).

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think now it's working, but it would be good if someone else can have a look 🙂

@awgymer
Copy link
Contributor

awgymer commented Dec 7, 2022

Seems to work OK for me!

@ewels ewels merged commit c8f5ab1 into nf-core:dev Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

modules create-test-yml broken for alternative remotes

4 participants