-
Notifications
You must be signed in to change notification settings - Fork 223
add remote-url to create-test-yml
#2090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #2090 +/- ##
==========================================
- Coverage 68.01% 68.01% -0.01%
==========================================
Files 43 43
Lines 5625 5628 +3
==========================================
+ Hits 3826 3828 +2
- Misses 1799 1800 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Hmm I don't think the logic in this command is that solid. I get the following in my custom repo: The thing is So really I don't think it should be using the |
|
I have added a new branch on git-lab called |
Do we need to change the tests in this branch or has a PR been made separately which uses that branch for tests in tools? |
|
we can start in this PR and then migrate some of the other remote-url tests for the other commands in separate PR(s). |
mirpedrol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think now it's working, but it would be good if someone else can have a look 🙂
|
Seems to work OK for me! |
Should resolve #2083. Not sure how to test it...