add newline before table 🤞🏻 #2128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewels
approved these changes
Dec 13, 2022
Member
ewels
left a comment
There was a problem hiding this comment.
The fact that prettier is now formatting the table whitespace for you is a good sign! 👍🏻
ewels
reviewed
Dec 13, 2022
README.md
Outdated
| | shell | shell config file | command | | ||
| | ----- | --------------------------------------- | -------------------------------------------------- | | ||
| | bash | ~/.bashrc | `eval "$(_NF_CORE_COMPLETE=bash_source nf-core)"` | | ||
| | Zsh | ~/.zshrc | `eval "$(_NF_CORE_COMPLETE=zsh_source nf-core)"` | |
Member
There was a problem hiding this comment.
Lower case?
Suggested change
| | Zsh | ~/.zshrc | `eval "$(_NF_CORE_COMPLETE=zsh_source nf-core)"` | | |
| | zsh | ~/.zshrc | `eval "$(_NF_CORE_COMPLETE=zsh_source nf-core)"` | |
Contributor
Author
There was a problem hiding this comment.
the authors don't seem to be consistent about it,think I prefer lower case, but I was following how Wikipedia writes it 🤷🏻
ewels
reviewed
Dec 13, 2022
Co-authored-by: Phil Ewels <[email protected]>
Contributor
Author
|
@nf-core-bot fix linting |
Codecov Report
@@ Coverage Diff @@
## dev #2128 +/- ##
=======================================
Coverage 71.41% 71.41%
=======================================
Files 77 77
Lines 8358 8358
=======================================
Hits 5969 5969
Misses 2389 2389 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mirpedrol
approved these changes
Dec 13, 2022
mashehu
commented
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2127 (hopefully)