Make jobs automatically resubmit for a much wider range of exit codes#2170
Make jobs automatically resubmit for a much wider range of exit codes#2170ewels merged 5 commits intonf-core:devfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #2170 +/- ##
==========================================
+ Coverage 71.54% 71.62% +0.08%
==========================================
Files 77 77
Lines 8367 8375 +8
==========================================
+ Hits 5986 5999 +13
+ Misses 2381 2376 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
FriederikeHanssen
left a comment
There was a problem hiding this comment.
sounds reasonable
|
I noticed that 104 is not in the list anymore. Does anyone remember why it was needed and if it's still relevant ? @ewels you were in fact involved in 104 getting into the pipeline template ;) #2170, which is a port from nf-core/rnaseq#56 |
|
Oof, good spot + detective work @muffato! No I have no memory of why it was there. Presumably saw it somewhere.. Had a quick look in Slack and didn't find a lot, but one or two messages / google suggest that it could crop up as an out-of-memory exit code sometimes. I guess we can add it back here 👍🏻 Anyone got some quick-fire groovy skills to add it into the array in a nice succinct way? Does |
|
Haven't properly tested the last commit but should hopefully be ok to merge now 👍🏻 |
muffato
left a comment
There was a problem hiding this comment.
A minor change to match the changelog with the code
Co-authored-by: Matthieu Muffato <[email protected]>
|
Black released a new stable update, which is why everything is breaking. Re-ran Black here to fix the tests. |
now
130..145Discussion in
#configschannel on the nf-core Slack.'cc @pontus @pcantalupo @muffato @FelixKrueger
'cc @nf-core/core for visibility as this is a fairly wide ranging change (though hopefully not controversial)
PR checklist
CHANGELOG.mdis updateddocsis updated