Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove dodgy sniffer code from samplesheet_check.py #2194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jfy133 merged 3 commits into from
Feb 27, 2023
Merged

Remove dodgy sniffer code from samplesheet_check.py #2194

jfy133 merged 3 commits into from
Feb 27, 2023

Conversation

@jfy133
Copy link
Member

@jfy133 jfy133 commented Feb 24, 2023 •
edited
Loading

See nf-core/funcscan#227 for more info

Closes #1539

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Feb 24, 2023 •
edited
Loading

Codecov Report

Merging #2194 (6de786c) into dev (7f30502) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #2194   +/-   ##
=======================================
  Coverage   71.57%   71.57%           
=======================================
  Files          77       77           
  Lines        8369     8369           
=======================================
  Hits         5990     5990           
  Misses       2379     2379

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

edmundmiller
edmundmiller approved these changes Feb 26, 2023
View reviewed changes
Copy link
Contributor

@edmundmiller edmundmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Maybe add a TODO to check for a header?

@jfy133
Copy link
Member Author

jfy133 commented Feb 26, 2023

Love it! Maybe add a TODO to check for a header?

I think @Midnighter said we actually already check for this when checking for the actual expected header string

@Midnighter
Copy link
Contributor

Midnighter commented Feb 26, 2023

Love it! Maybe add a TODO to check for a header?

I think @Midnighter said we actually already check for this when checking for the actual expected header string

Indeed! Check lines 194-202.

@jfy133 jfy133 merged commit cf00868 into dev Feb 27, 2023
@jfy133 jfy133 deleted the remove-sniffer branch February 27, 2023 07:20
@mirpedrol mirpedrol mentioned this pull request Mar 9, 2023
Closed
@nservant nservant mentioned this pull request Mar 23, 2023
Open
@dependabot dependabot bot mentioned this pull request May 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Midnighter Midnighter Midnighter approved these changes

@edmundmiller edmundmiller edmundmiller approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jfy133 @Midnighter @edmundmiller