Add tests for nf-core subworkflows create-test-yml
#2219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #2219 +/- ##
==========================================
+ Coverage 71.99% 72.96% +0.96%
==========================================
Files 78 78
Lines 8385 8385
==========================================
+ Hits 6037 6118 +81
+ Misses 2348 2267 -81
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
Author
|
@nf-core-bot fix linting |
0039e2e to
49c3bd9
Compare
49c3bd9 to
a661087
Compare
mashehu
approved these changes
Mar 29, 2023
Contributor
mashehu
left a comment
There was a problem hiding this comment.
Looks good! Thanks for doing this!
Co-authored-by: Matthias Hörtenhuber <[email protected]>
mirpedrol
approved these changes
Mar 29, 2023
fabianegli
reviewed
Mar 29, 2023
fabianegli
reviewed
Mar 29, 2023
[skip ci]
Contributor
Author
|
Thanks for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds unit-tests for
nf-core subworkflows create-test-yml.The code in
nf_core/subworkflows/test_yml_builder.pyis very similar to its module equivalent, so the new tests are more or less a copy of the module tests. Maybe it would be worth refactoringSubworkflowTestYmlBuilderandModuleTestYmlBuilderto avoid code duplication?Closes #1895
PR checklist
CHANGELOG.mdis updated