Put all input files into channels in template #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Rebased against dev. Sorry @drpatelh - I think I saw a comment from you before I did it which was lost... |
Codecov Report
@@ Coverage Diff @@
## dev #223 +/- ##
=======================================
Coverage 90.83% 90.83%
=======================================
Files 8 8
Lines 927 927
=======================================
Hits 842 842
Misses 85 85Continue to review full report at Codecov.
|
ewels
reviewed
Dec 7, 2018
nf_core/pipeline-template/{{cookiecutter.name_noslash}}/main.nf
Outdated
Show resolved
Hide resolved
nf_core/pipeline-template/{{cookiecutter.name_noslash}}/main.nf
Outdated
Show resolved
Hide resolved
Co-Authored-By: apeltzer <[email protected]>
Co-Authored-By: apeltzer <[email protected]>
Member
Author
|
I think we don't really need it... RNAseq has the same issue and apparently having the file inside still doesn't resolve the problem unfortunately :-( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This puts all files into separate channels that should remove the issues people had when e.g. linking across filesystems (e.g. home of logged in user is on different FS than the workDir).
#222
PR checklist
CHANGELOG.mdis updated