Linting error if quay.io found in biocontainer name#2278
Merged
adamrtalbot merged 8 commits intonf-core:devfrom May 9, 2023
Merged
Linting error if quay.io found in biocontainer name#2278adamrtalbot merged 8 commits intonf-core:devfrom
adamrtalbot merged 8 commits intonf-core:devfrom
Conversation
Changes: - Linting error if container starts with quay.io/biocontainers but not quay.io/biocontainers/mulled Fixes nf-core#2276
mashehu
approved these changes
May 4, 2023
ewels
requested changes
May 5, 2023
Member
ewels
left a comment
There was a problem hiding this comment.
Wait, need to add a self.passed when the test is passing..
Contributor
Author
Do we want one for the general container? E.g. if docker image name looks valid ✅ |
Puts container status check into a single if statement
Contributor
Author
Nevermind, I've copied the existing format. Also updated one of the checks to occur once. |
Contributor
Author
|
@drpatelh This PR now changes if you are removing |
Codecov Report
@@ Coverage Diff @@
## dev #2278 +/- ##
==========================================
+ Coverage 73.05% 73.12% +0.07%
==========================================
Files 77 77
Lines 8424 8433 +9
==========================================
+ Hits 6154 6167 +13
+ Misses 2270 2266 -4
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Fixes #2276
PR checklist
CHANGELOG.mdis updateddocsis updated