Fix quay.io detection in simple docker names #2281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Detects simple docker name by having a single slash and colon in the string - adds quay.io as default registry for this docker container - Should fix problems where nfcore/ubuntu:20.04 did not find correct URL fixes nf-core#2280
sateeshperi
reviewed
May 5, 2023
FriederikeHanssen
approved these changes
May 5, 2023
Contributor
Author
|
Thanks @FriederikeHanssen and @drpatelh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detects docker name by single slash and colon in string.
PR checklist
CHANGELOG.mdis updateddocsis updatedFixes #2280