modify template to use nf-validation plugin for parameter validation#2300
modify template to use nf-validation plugin for parameter validation#2300mirpedrol merged 11 commits intonf-core:devfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report
@@ Coverage Diff @@
## dev #2300 +/- ##
==========================================
- Coverage 72.97% 72.93% -0.04%
==========================================
Files 78 78
Lines 8732 8732
==========================================
- Hits 6372 6369 -3
- Misses 2360 2363 +3
|
Co-authored-by: Matthias Hörtenhuber <[email protected]>
|
I think we should also remove the |
As we don't have tooling to help create the JSON schema for a sample sheet, we thought that it would be best to not make it mandatory in the template update, and instead let it to the pipeline maintainers to decide if they want to add it or wait. |
Good point! Thanks for clarifying! |
Closes #1543
The validation of
nextflow_schema.jsonfiles from nf-core pipelines is now part of a core Nextflow plugin: nextflow-io/nf-validation#5Test in nf-core/testpipeline
Also tested with real pipelines rnaseq, funcscan and sarek.
Functions can be imported to a pipeline with include { paramsHelp, paramsSummaryMap, paramsSummaryLog } from 'plugin/nf-validation'
Schema validation code from the pipeline template NfcoreSchema.groovy and MainWorkflow.groovy is removed.
Validate a sample sheet with a JSON schema.PR checklist
CHANGELOG.mdis updateddocsis updated