Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@mirpedrol
Copy link
Member

Lint for null values in the nextflow_schema.json to avoid errors where nulls are converted to "None" by the schema tooling. nf-core/sarek#1116 (comment)

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@mirpedrol mirpedrol requested a review from mashehu June 20, 2023 07:09
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #2328 (c10c891) into dev (37c3d06) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##              dev    #2328      +/-   ##
==========================================
- Coverage   72.86%   72.86%   -0.01%     
==========================================
  Files          78       78              
  Lines        8774     8777       +3     
==========================================
+ Hits         6393     6395       +2     
- Misses       2381     2382       +1     
Impacted Files Coverage Δ
nf_core/schema.py 78.77% <66.66%> (-0.07%) ⬇️

Copy link
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mirpedrol mirpedrol merged commit cf15617 into nf-core:dev Jun 20, 2023
@mirpedrol mirpedrol deleted the lint-schema-null-values branch June 20, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants