Remove default false from json schema #2376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirpedrol
commented
Jul 17, 2023
Codecov Report
@@ Coverage Diff @@
## dev #2376 +/- ##
==========================================
+ Coverage 72.81% 72.85% +0.03%
==========================================
Files 78 78
Lines 8888 8888
==========================================
+ Hits 6472 6475 +3
+ Misses 2416 2413 -3 |
mashehu
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since v2.9 defaults to false were introduced in the nextflow schema. They are not required, as any value not evaluating to true won't be printed by
printSummaryParams(). Those defaults are also automatically removed bynf-core schema build.PR checklist
CHANGELOG.mdis updateddocsis updated