Porting over improvements from comparison with rnaseq pipeline #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
All looks good to me. Are you going to make any more changes @ewels ? Just waiting for Travis CI to pass. |
drpatelh
requested changes
Mar 13, 2019
Member
Author
|
I'm not planning to make any changes for now, now. At least, not until I do the same process for other pipelines, but that'll be a different day / week / month. Phil |
drpatelh
approved these changes
Mar 13, 2019
Member
|
The last commit to |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been syncing nf-core/rnaseq with the template pipeline and found a few things in the template that needed tidying up and/or porting from the rnaseq.
Whilst I was there, I also added a new function to check the hostname against those set in nf-core/configs (see nf-core/configs#33) and throws a warning if it looks like the correct profile was not set.
Other stuff: