Get the latest release with nf-core download #287
Merged
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apeltzer
approved these changes
Mar 19, 2019
Member
|
Hm something weird with the tests happening here... :-( |
Member
Author
|
Ah, it's because the test uses fake data that is missing a bunch of keys that the real data has. No problem - I will just make the code a little more tolerant. |
apeltzer
approved these changes
Mar 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@orzechoj spotted that using
nf-core downloadwithout a specific release would not pull the latest release by default. In fact, it just grabs the first in the list, which is probably the oldest.This PR just sorts the list of releases by release date, so it now gets the most recent release instead 👍