Linting - don't reverse conda channel order #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why this code was there, but for some reason we were going through the conda channel order in reverse.
When packages are only in one channel, this didn't have any negative effect (except for slower lint execution times and more API calls). However, when packages were in multiple channels with different version numbers, it could cause the linting to fail incorrectly (cf. nf-core/atacseq#26)
Just removing the
reverse()seems to fix this behaviour. Arguably we could extend the linting to check subsequent channels if the correct version isn't found in the first found, but I think it's very unlikely that this will happen so I can't be bothered now.Phil