Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@KochTobi
Copy link

@KochTobi KochTobi commented Apr 6, 2019

AWS Batch fix

  • Remove duplicate checks: Decided for s3: since it is more likely that a local outdir starts with s3
  • Remove check for s3: prefix of work-dir since it is removed by nextflow and therefore not found at this state. Nextflow checks for the correct work-dir location when executing with awsbatch by itself.
  • Nextflow removes the s3:/ prefix from the workdir now. Removed check to make pipeline executable again on awsbatch.

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/tools/tree/master/.github/CONTRIBUTING.md

Tobias added 2 commits April 6, 2019 21:45
remove workdir check since the s3 prefix is removed by nextflow
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ewels ewels merged commit f0c1bf5 into nf-core:dev Apr 7, 2019
@KochTobi KochTobi deleted the awsbatchFix branch April 8, 2019 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants