Specify yaml Loader argument #322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since PyYAML 5.1, a warning is thrown when yaml.load() is called without a loader argument. More info: https://github.com/yaml/pyyaml/wiki/PyYAML-yaml.load(input)-Deprecation
Member
|
Thanks for fixing this @phue ! Was very annoying. Travis failing because |
Member
Author
|
I also missed some yaml.load() statements in the tests. Will fix later 👍 |
Member
Author
|
Ok done. |
Member
|
Maybe something that @sven1103 knows most about as one of our python gurus ;-) |
Member
Author
|
Using yaml.safe_load() seems to fix the issue with python2. This is good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since PyYAML 5.1, a warning is thrown when yaml.load() is called without a loader argument.
More info:
https://github.com/yaml/pyyaml/wiki/PyYAML-yaml.load(input)-Deprecation
Many thanks to contributing to nf-core/tools!
Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).
PR checklist
CHANGELOG.mdis updatedLearn more about contributing: https://github.com/nf-core/tools/tree/master/.github/CONTRIBUTING.md