Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix arbitrarily nested params schema linting #3443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 21, 2025
Merged

Fix arbitrarily nested params schema linting #3443

merged 4 commits into from
Feb 21, 2025

Conversation

@awgymer
Copy link
Contributor

@awgymer awgymer commented Feb 5, 2025 •
edited
Loading

Uses a recursive function to strip "required" key from json schema object.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@awgymer
fix(schema lint defaults): use a recursive function to strip all inst…
c9d5bba 
…ances of "required" key from schema for linting
@awgymer awgymer requested a review from mirpedrol February 5, 2025 03:17
@codecov
Copy link

codecov bot commented Feb 5, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.61%. Comparing base (d4f99fc) to head (25b78ca).
Report is 5 commits behind head on dev.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mirpedrol
mirpedrol approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@mirpedrol mirpedrol linked an issue Feb 21, 2025 that may be closed by this pull request
Support double nesting in nf-schema or required parameters #3437
Closed
@mirpedrol mirpedrol enabled auto-merge February 21, 2025 13:59
@mirpedrol mirpedrol merged commit 8382b29 into nf-core:dev Feb 21, 2025
93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mirpedrol mirpedrol mirpedrol approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support double nesting in nf-schema or required parameters

3 participants

@awgymer @mirpedrol @nf-core-bot