Thanks to visit codestin.com
Credit goes to github.com

Skip to content

update multiqc version to fix utils test #3853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ningyuxin1999 merged 2 commits into from
Oct 28, 2025
Merged

update multiqc version to fix utils test #3853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47752ac
update multiqc version to fix utils test
mashehu Oct 28, 2025
a5ed60b
[automated] Update CHANGELOG.md
nf-core-bot Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

### General

- update multiqc version to fix utils test ([#3853](https://github.com/nf-core/tools/pull/3853))

### Template

### Linting
Expand Down
10 changes: 5 additions & 5 deletions tests/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ def test_request_cant_create_cache(self, mock_exists, mock_mkdir):
nf_core.utils.setup_requests_cachedir()

def test_pip_package_pass(self):
result = nf_core.utils.pip_package("multiqc=1.10")
result = nf_core.utils.pip_package("multiqc=1.32")
assert isinstance(result, dict)

@mock.patch("requests.get")
Expand All @@ -118,7 +118,7 @@ def test_pip_package_timeout(self, mock_get):
mock_get.side_effect = requests.exceptions.Timeout()
# Now do the test
with pytest.raises(LookupError):
nf_core.utils.pip_package("multiqc=1.10")
nf_core.utils.pip_package("multiqc=1.32")

@mock.patch("requests.get")
def test_pip_package_connection_error(self, mock_get):
Expand All @@ -128,7 +128,7 @@ def test_pip_package_connection_error(self, mock_get):
mock_get.side_effect = requests.exceptions.ConnectionError()
# Now do the test
with pytest.raises(LookupError):
nf_core.utils.pip_package("multiqc=1.10")
nf_core.utils.pip_package("multiqc=1.32")

def test_pip_erroneous_package(self):
"""Tests the PyPi API package information query"""
Expand All @@ -151,10 +151,10 @@ def test_get_repo_releases_branches_not_nf_core(self):
wfs.get_remote_workflows()
pipeline, wf_releases, wf_branches = nf_core.utils.get_repo_releases_branches("MultiQC/MultiQC", wfs)
for r in wf_releases:
if r.get("tag_name") == "v1.10":
if r.get("tag_name") == "v1.32":
break
else:
raise AssertionError("MultiQC release v1.10 not found")
raise AssertionError("MultiQC release v1.32 not found")
assert "main" in wf_branches.keys()

def test_get_repo_releases_branches_not_exists(self):
Expand Down