Make bump-version snapshot test more stable #3865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mashehu
approved these changes
Nov 3, 2025
Contributor
mashehu
left a comment
There was a problem hiding this comment.
Thanks!
I have a feeling you will run into quite a lot of those 😁
Contributor
Author
|
@mashehu yes, maybe let this PR open until I have found more of these. |
Contributor
|
just a heads up. we will hopefully make a release this week. just in case you want to get this into a stable version. 🙂 |
Uses the pipeline slug from the created pipeline rather than using hard coded org and name inside of the test.
Use the pipeline slug from the prefix and name of the pipeline object to check for valid output.
by using pipeline slug from pipeline object.
b478e35 to
8db0c7b
Compare
mirpedrol
approved these changes
Nov 5, 2025
Contributor
Author
|
@mirpedrol @mashehu I think this can be merged for now. Thank you. |
Contributor
|
@nf-core-bot changelog |
mashehu
approved these changes
Nov 5, 2025
Contributor
|
@nf-core-bot changelog |
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the pipeline slug from the created pipeline rather than using hard coded org and name inside of the test.
PR checklist
CHANGELOG.mdis updateddocsis updated