Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix pytest matrix setup #3888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mashehu merged 8 commits into from
Nov 12, 2025
Merged

Fix pytest matrix setup #3888

mashehu merged 8 commits into from
Nov 12, 2025

Conversation

@rrahn
Copy link
Contributor

@rrahn rrahn commented Nov 10, 2025 •
edited
Loading

Fixes the broken pytest setup job.
The general issue with the current workflow is that it does not work as intended. The outputs of the setup job get merged no matter how big the execution matrix is. This explains why always 3.14 tests were run. It overwrites the setting for py3.10.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@rrahn rrahn force-pushed the test-pytest-trigger branch 2 times, most recently from 06faf0c to 682cb23 Compare November 10, 2025 16:18
@rrahn rrahn force-pushed the test-pytest-trigger branch from 682cb23 to 27c7b3e Compare November 10, 2025 16:25
@rrahn rrahn changed the title test pytest condition Fix pytest matrix setup Nov 10, 2025
@rrahn rrahn marked this pull request as ready for review November 10, 2025 16:27
@mashehu
Copy link
Contributor

mashehu commented Nov 11, 2025

Suggesting a simpler approach: rrahn#1

rrahn and others added 3 commits November 12, 2025 12:21
@rrahn @mashehu
Apply suggestion from @mashehu
6936d79 
Co-authored-by: Matthias Hörtenhuber <[email protected]>
@rrahn
Merge pull request #1 from mashehu/simpler-pytest-trigger
77d10e1 
simpler ternary syntax to run tests only for 3.10 with dev or both for PRs to main
@rrahn
strategy fix expression
1772870
@codecov
Copy link

codecov bot commented Nov 12, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.44%. Comparing base (9c306ee) to head (1772870).
⚠️ Report is 1 commits behind head on dev.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mashehu mashehu merged commit ea63385 into nf-core:dev Nov 12, 2025
114 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mashehu mashehu mashehu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rrahn @mashehu @nf-core-bot