Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@rrahn
Copy link
Contributor

@rrahn rrahn commented Nov 12, 2025

These tests do a direct request of a github API call, for which we receive API rate limit errors due to running on self-hosted runners.
This fixes this by populating the GITHUB_TOKEN to the test cases.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.46%. Comparing base (eae5c97) to head (0fa71ea).
⚠️ Report is 25 commits behind head on dev.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- name: Test with pytest
id: pytest
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Copy link
Contributor Author

@rrahn rrahn Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just saw, that GITHUB_TOKEN is already set on workflow level. I guess, this is then not needed.

@rrahn
Copy link
Contributor Author

rrahn commented Nov 14, 2025

@mashehu I removed the github token in the step env.

rrahn and others added 3 commits November 14, 2025 15:15
Removed GITHUB_TOKEN from pytest environment since it is already present on workflow level.
@rrahn rrahn force-pushed the fix/gh_api_rate_limit branch from 40901c1 to 0fa71ea Compare November 14, 2025 14:17
@mashehu mashehu merged commit 3619d80 into nf-core:dev Nov 17, 2025
114 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants