Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Linting: Add linting of topics #3902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mirpedrol merged 3 commits into from
Nov 17, 2025
Merged

Linting: Add linting of topics #3902

mirpedrol merged 3 commits into from
Nov 17, 2025

Conversation

@mirpedrol
Copy link
Member

@mirpedrol mirpedrol commented Nov 14, 2025

Add linting of the topics section in the meta.yml file and the funcitonality to fix them.

@mirpedrol mirpedrol requested a review from mashehu November 14, 2025 15:15
mashehu
mashehu reviewed Nov 14, 2025
View reviewed changes
mashehu
mashehu approved these changes Nov 14, 2025
View reviewed changes
Copy link
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need more specific tests for this?

@mashehu
Copy link
Contributor

mashehu commented Nov 17, 2025

I think we need to updated bamstats/generalstats with the new topic structure for the test_main_nf to pass

@codecov
Copy link

codecov bot commented Nov 17, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.48%. Comparing base (eae5c97) to head (062725c).
⚠️ Report is 29 commits behind head on dev.

Files with missing lines Patch % Lines
nf_core/modules/lint/meta_yml.py 89.47% 2 Missing ⚠️
nf_core/components/nfcore_component.py 88.88% 1 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mirpedrol mirpedrol merged commit 36a5c73 into nf-core:dev Nov 17, 2025
197 of 198 checks passed
@mirpedrol mirpedrol deleted the fix-eval-parsing branch November 17, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mashehu mashehu mashehu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mirpedrol @mashehu @nf-core-bot