Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor(store): drop ɵwrapObserverCalls #2371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2025
Merged

refactor(store): drop ɵwrapObserverCalls #2371

merged 1 commit into from
Sep 5, 2025

Conversation

@arturovt
Copy link
Member

@arturovt arturovt commented Sep 5, 2025

No description provided.

@nx-cloud
Copy link

nx-cloud bot commented Sep 5, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit e705d7b

Command Status Duration Result
nx run-many --target=test --all --configuration... ✅ Succeeded 2m 12s View ↗
nx lint-types store ✅ Succeeded 4s View ↗
nx run-many --target=lint --all --exclude=creat... ✅ Succeeded 6s View ↗
nx run-many --target=build --all ✅ Succeeded 1m 22s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-05 21:31:27 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 5, 2025

Open in StackBlitz

@ngxs/devtools-plugin

npm i https://pkg.pr.new/@ngxs/devtools-plugin@2371

@ngxs/form-plugin

npm i https://pkg.pr.new/@ngxs/form-plugin@2371

@ngxs/hmr-plugin

npm i https://pkg.pr.new/@ngxs/hmr-plugin@2371

@ngxs/router-plugin

npm i https://pkg.pr.new/@ngxs/router-plugin@2371

@ngxs/storage-plugin

npm i https://pkg.pr.new/@ngxs/storage-plugin@2371

@ngxs/store

npm i https://pkg.pr.new/@ngxs/store@2371

@ngxs/websocket-plugin

npm i https://pkg.pr.new/@ngxs/websocket-plugin@2371

commit: e705d7b

@bundlemon
Copy link

bundlemon bot commented Sep 5, 2025

BundleMon

Files updated (2)
Status Path Size Limits
✅ fesm2022/ngxs-store.mjs
 104.27KB (+214B +0.2%) 105KB / +0.5%
✅ fesm2022/ngxs-store-internals.mjs
 13.46KB (-170B -1.22%) 15KB / +0.5%
Unchanged files (4)
Status Path Size Limits
✅ fesm2022/ngxs-store-internals-testing.mjs
 10.32KB 13KB / +0.5%
✅ fesm2022/ngxs-store-operators.mjs
 6.05KB 7KB / +0.5%
✅ fesm2022/ngxs-store-plugins.mjs
 2.37KB 3KB / +0.5%
✅ fesm2022/ngxs-store-experimental.mjs
 574B 2KB / +0.5%

Total files change +44B +0.03%

Groups updated (1)
Status Path Size Limits
✅ @ngxs/store(fesm2022)[gzip]
./fesm2022/*.mjs
 33.67KB (+41B +0.12%) +1%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@bundlemon
Copy link

bundlemon bot commented Sep 5, 2025

BundleMon (NGXS Plugins)

Unchanged files (9)
Status Path Size Limits
✅ Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin.m
js
 4.05KB +0.5%
✅ Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin.mjs
 2.93KB +0.5%
✅ Plugins(fesm2022)[gzip]
hmr-plugin/fesm2022/ngxs-hmr-plugin.mjs
 2.72KB +0.5%
✅ Plugins(fesm2022)[gzip]
websocket-plugin/fesm2022/ngxs-websocket-plug
in.mjs
 2.58KB +0.5%
✅ Plugins(fesm2022)[gzip]
form-plugin/fesm2022/ngxs-form-plugin.mjs
 2.47KB +0.5%
✅ Plugins(fesm2022)[gzip]
devtools-plugin/fesm2022/ngxs-devtools-plugin
.mjs
 2.23KB +0.5%
✅ Plugins(fesm2022)[gzip]
logger-plugin/fesm2022/ngxs-logger-plugin.mjs
 2.03KB +0.5%
✅ Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin-i
nternals.mjs
 947B +0.5%
✅ Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin-int
ernals.mjs
 453B +0.5%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
✅ All Plugins(fesm2022)[gzip]
./-plugin/fesm2022/.mjs
 20.38KB +0.5%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@bundlemon
Copy link

bundlemon bot commented Sep 5, 2025

BundleMon (Integration Projects)

Unchanged files (1)
Status Path Size Limits
✅ Main bundles(Gzip)
hello-world-ng20/dist-integration/browser/mai
n-(hash).js
 67.15KB +1%

Total files change +10B +0.01%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@arturovt arturovt marked this pull request as ready for review September 5, 2025 21:41
@arturovt arturovt merged commit 5a744a3 into master Sep 5, 2025
11 of 13 checks passed
@arturovt arturovt deleted the refactor/drop-wrap branch September 5, 2025 21:41
markwhitfeld added a commit that referenced this pull request Oct 10, 2025
@markwhitfeld
Revert "refactor(store): drop ɵwrapObserverCalls (#2371)"
d46daea 
This reverts commit 5a744a3.
markwhitfeld added a commit that referenced this pull request Oct 10, 2025
@markwhitfeld
Revert "refactor(store): drop ɵwrapObserverCalls (#2371)"
89112d3 
This reverts commit 5a744a3.
markwhitfeld added a commit that referenced this pull request Oct 10, 2025
@markwhitfeld
revert: "refactor(store): drop ɵwrapObserverCalls (#2371)" (#2383)
0b2ec01 
This reverts commit 5a744a3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markwhitfeld markwhitfeld Awaiting requested review from markwhitfeld markwhitfeld is a code owner

@kuncevic kuncevic Awaiting requested review from kuncevic kuncevic is a code owner

@Carniatto Carniatto Awaiting requested review from Carniatto Carniatto is a code owner

@poloagustin poloagustin Awaiting requested review from poloagustin poloagustin is a code owner

@joaqcid joaqcid Awaiting requested review from joaqcid joaqcid is a code owner

@splincode splincode Awaiting requested review from splincode splincode is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@arturovt