Thanks to visit codestin.com
Credit goes to github.com

Skip to content

revert: "refactor(store): drop ɵwrapObserverCalls (#2371)" #2383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2025
Merged

revert: "refactor(store): drop ɵwrapObserverCalls (#2371)" #2383

merged 1 commit into from
Oct 10, 2025

Conversation

markwhitfeld
Copy link
Member

This reverts commit 5a744a3.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

This previous commit was merged, and then parth of the functionality was reverted but the shared code was never restored, resulting in slightly bigger bundle size.

What is the new behavior?

Re-add the shared code.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@nx-cloud
Copy link

nx-cloud bot commented Oct 10, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 89112d3

Command Status Duration Result
nx run-many --target=test --all --configuration... ✅ Succeeded 1m 16s View ↗
nx run-many --target=lint --all --configuration... ✅ Succeeded 6s View ↗
nx lint-types store ✅ Succeeded <1s View ↗
nx run-many --target=build --all ✅ Succeeded 4s View ↗

☁️ Nx Cloud last updated this comment at 2025-10-10 10:56:27 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 10, 2025

Open in StackBlitz

@ngxs/devtools-plugin

npm i https://pkg.pr.new/@ngxs/devtools-plugin@2383

@ngxs/form-plugin

npm i https://pkg.pr.new/@ngxs/form-plugin@2383

@ngxs/hmr-plugin

npm i https://pkg.pr.new/@ngxs/hmr-plugin@2383

@ngxs/router-plugin

npm i https://pkg.pr.new/@ngxs/router-plugin@2383

@ngxs/storage-plugin

npm i https://pkg.pr.new/@ngxs/storage-plugin@2383

@ngxs/store

npm i https://pkg.pr.new/@ngxs/store@2383

@ngxs/websocket-plugin

npm i https://pkg.pr.new/@ngxs/websocket-plugin@2383

commit: 89112d3

@bundlemon
Copy link

bundlemon bot commented Oct 10, 2025

BundleMon

Files updated (2)
Status Path Size Limits
✅ fesm2022/ngxs-store-internals.mjs
 13.62KB (+27B +0.19%) 15KB / +0.5%
✅ fesm2022/ngxs-store.mjs
 104.33KB (-214B -0.2%) 105KB / +0.5%
Unchanged files (4)
Status Path Size Limits
✅ fesm2022/ngxs-store-internals-testing.mjs
 10.32KB 13KB / +0.5%
✅ fesm2022/ngxs-store-operators.mjs
 6.05KB 7KB / +0.5%
✅ fesm2022/ngxs-store-plugins.mjs
 2.37KB 3KB / +0.5%
✅ fesm2022/ngxs-store-experimental.mjs
 574B 2KB / +0.5%

Total files change -187B -0.13%

Groups updated (1)
Status Path Size Limits
✅ @ngxs/store(fesm2022)[gzip]
./fesm2022/*.mjs
 33.65KB (-99B -0.29%) +1%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@bundlemon
Copy link

bundlemon bot commented Oct 10, 2025

BundleMon (NGXS Plugins)

Unchanged files (9)
Status Path Size Limits
✅ Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin.m
js
 4.05KB +0.5%
✅ Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin.mjs
 3.4KB +0.5%
✅ Plugins(fesm2022)[gzip]
hmr-plugin/fesm2022/ngxs-hmr-plugin.mjs
 2.72KB +0.5%
✅ Plugins(fesm2022)[gzip]
websocket-plugin/fesm2022/ngxs-websocket-plug
in.mjs
 2.58KB +0.5%
✅ Plugins(fesm2022)[gzip]
form-plugin/fesm2022/ngxs-form-plugin.mjs
 2.47KB +0.5%
✅ Plugins(fesm2022)[gzip]
devtools-plugin/fesm2022/ngxs-devtools-plugin
.mjs
 2.23KB +0.5%
✅ Plugins(fesm2022)[gzip]
logger-plugin/fesm2022/ngxs-logger-plugin.mjs
 2.03KB +0.5%
✅ Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin-i
nternals.mjs
 947B +0.5%
✅ Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin-int
ernals.mjs
 453B +0.5%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
✅ All Plugins(fesm2022)[gzip]
./-plugin/fesm2022/.mjs
 20.85KB +0.5%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@bundlemon
Copy link

bundlemon bot commented Oct 10, 2025

BundleMon (Integration Projects)

Files updated (1)
Status Path Size Limits
✅ Main bundles(Gzip)
hello-world-ng20/dist-integration/browser/mai
n-(hash).js
 67.19KB (-24B -0.03%) +1%

Total files change -24B -0.03%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@markwhitfeld markwhitfeld merged commit 0b2ec01 into master Oct 10, 2025
16 checks passed
@markwhitfeld markwhitfeld deleted the mark/revert-drop-wrapObserverCalls-pr-2371 branch October 10, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arturovt arturovt arturovt approved these changes

@kuncevic kuncevic Awaiting requested review from kuncevic kuncevic is a code owner

@Carniatto Carniatto Awaiting requested review from Carniatto Carniatto is a code owner

@poloagustin poloagustin Awaiting requested review from poloagustin poloagustin is a code owner

@joaqcid joaqcid Awaiting requested review from joaqcid joaqcid is a code owner

@splincode splincode Awaiting requested review from splincode splincode is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@markwhitfeld @arturovt