Conversation
mseri
approved these changes
Feb 27, 2020
Member
|
We have added lots lately but no new test. Should we add some test cases? |
Member
|
Agree, unit tests have been very useful in owl development. It is better to keep sufficient coverage of the functions in owl. |
Member
Author
|
added unit test for |
ryanrhymes
approved these changes
Feb 28, 2020
mseri
added a commit
to mseri/opam-repository
that referenced
this pull request
Mar 3, 2020
CHANGES: * owl: sync opam files versioning * added stack function (owlbarn/owl#506) * Owl now compatible with latest version of Ctypes (owlbarn/owl#508) * Fix bug in _squeeze_broadcast (owlbarn/owl#503) * using extended indexing operator since ocaml 4.10.0 * [breaking] Drop support for ocaml < 4.10.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added
stackfunction to Ndarray modules as discussed in #505