Owl now compatible with latest version of Ctypes#508
Conversation
|
Do youneed to run ocamlformat on the generated files? I am surprised that the diff is so large |
hmmm I didn't actually apply ocamlformat, but maybe that's the problem... |
Sorry, that’s exactly what I meant, if you needed to ocamlformat them to reduce the diff |
|
Indeed, after applying ocamlformat the diffs are smaller |
mseri
left a comment
There was a problem hiding this comment.
Once a lower bound on ctypes is added, this is good to merge for me. I may also backport the changes and draft a 0.8.1 release without 4.10.0 as well. Then I suggest we release 0.9.0 moving to ocaml 4.10
|
If you haven't already, it'd be worth testing this against ctypes 0.17.1 (which makes some small changes related to the internal-interface changes in 0.17.0). |
|
Indeed, thanks! @tachukao can you pin the latest ctypes and check? |
|
I can't find ctypes 0.17.1 on opam yet, but I tried pinning to the dev version on github, and it seems to work. |
CHANGES: * owl: sync opam files versioning * added stack function (owlbarn/owl#506) * Owl now compatible with latest version of Ctypes (owlbarn/owl#508) * Fix bug in _squeeze_broadcast (owlbarn/owl#503) * using extended indexing operator since ocaml 4.10.0 * [breaking] Drop support for ocaml < 4.10.0
This PR makes Owl compatible with the latest version of Ctypes see #489
Changes are made to the lapacke and cblas parser and generated files as well as
owl_maths_special.ml.