packaging: improve deps, polish spec and fix split of files #591

pirat89 · 2020-01-08T15:50:03Z

Originally we had troubles with dependencies and release processes
as we have been strict about versions of leapp and repositories,
specified in the leapp rpm. As well, we would like to ensure that
currently we will install all rpms when leapp tool is installed.

So we are going to keep dependency on leapp-repository, but
without a version specification. We are going to left the
reponsiblity for version check on repositories itself.

As well, python?-leapp rpms will provide new leapp-framework
capability informing about incompatible changes or new features that
affects leapp repository (like changes in stdlib). This one will
be more flexible than official versioning and can be updated per
PR (see comment in the spec file for more details).

As well, I added several new macros in the SPEC, so there is no need
to update same values on several places anymore. Just update macros
in the top of the SPEC.

There is missing solution for Py3 framework. See the comments for more details, and this. I commented out the capability for python3-leapp now, so we can resolve it even later.

Tasks:

update leapp.spec
create documentation
prepare PR in leapp-repository

centos-ci · 2020-01-08T15:50:10Z

Can one of the admins verify this patch?

See the leapp PR for more details: oamg/leapp#591 In short, leapp-repository takes care that compatible version of the framework is installed.

pirat89 · 2020-01-08T16:16:50Z

@oamg/developers - the name of capability can be changed yet. I am waiting with writting of the documentation until we have agreement on the solution.

pirat89 · 2020-01-08T18:33:02Z

@oamg/developers Here is prepared tmp repository with several leapp and leapp-repository builds with various provides & requirements:

[copr:copr.fedorainfracloud.org:pstodulk:leapp-deps-test]
name=Copr repo for leapp-deps-test owned by pstodulk
baseurl=https://copr-be.cloud.fedoraproject.org/results/pstodulk/leapp-deps-test/epel-7-$basearch/
type=rpm-md
skip_if_unavailable=True
gpgcheck=1
gpgkey=https://copr-be.cloud.fedoraproject.org/results/pstodulk/leapp-deps-test/pubkey.gpg
repo_gpgcheck=0
enabled=1
enabled_metadata=1

https://copr.fedorainfracloud.org/coprs/pstodulk/leapp-deps-test

drehak · 2020-01-23T16:16:20Z

Given that this is a pretty big change in deps, shouldn't this be mentioned in the %changelog? Or do we not care about that section?

pirat89 · 2020-01-24T12:17:40Z

@drehak: we never care about %changelog in upstream. this will be kept unchanged forever. That's why we have changlog for releases. Downstream takes care of %changelog.

drehak

Looks good to me.

pirat89 · 2020-02-04T14:55:40Z

I will probably document that in the following PR as documentation needs more changes anyway and I am kind of sick now. keeping that opened, until @bocekm finishes review of Beta/HTB, so we willl be able to merge both things together (as in both cases, other prs will have to be rebased).

Originally we had troubles with dependencies and release processes as we have been strict about versions of leapp and repositories, specified in the leapp rpm. As well, we would like to ensure that currently we will install all rpms when leapp tool is installed. So we are going to keep dependency on leapp-repository, but without a version specification. We are going to left the reponsiblity for version check on repositories itself. As well, python?-leapp rpms will provide new leapp-framework capability informing about incompatible changes or new features that affects leapp repository (like changes in stdlib). This one will be more flexible than official versioning and can be updated per PR (see comment in the spec file for more details). As well, I added several new macros in the SPEC, so there is no need to update same values on several places anymore. Just update macros in the top of the SPEC.

Move all leapp and snactor files into related rpms instead of keeping them inside the python?-leapp (framework) rpms.

See the comment in spec and: https://serverfault.com/questions/411444/rpm-set-required-somepackage-0-5-0-and-somepackage-0-6-0 In case that on some system (repo) both python?-leapp rpms are provided, it could happen that 2 different rpms will be installed and compatibility will be broken.

pirat89 · 2020-02-12T20:54:55Z

It's broken travis ci - issues with pylint running on Python3 because of versions of pylint. That's unrelated to the changes in the PR. As well, leapp bot issue is unrelated to the PR.

See the leapp PR for more details: oamg/leapp#591 In short, leapp-repository takes care that compatible version of the framework is installed.

## Packaging - Add BuildRequires on python2-setuptools - Add new dependency on python?-requests - Add unversioned dependency on leapp-repository and provide the leapp-framework capability in python2-leapp (see docs about "new dependency mechanism") (oamg#591) - Move all leapp and snactor files into related rpms istead of python?-leapp (oamg#591) - Remove dependency on Jinja2 ## Framework ### Fixes - Fix json export capabilities using serialization (oamg#598) ### Enhancements - Add the DESKTOP tag for the leapp report (oamg#612) - Dialogs are non-interactive and redesigned significantly; but in beta support (see the known issue) - Introduce DialogModel that could be processed by actors to add related information into the report (oamg#589) - Introduce Workflow API (see the tutorial) (oamg#618) - Report inhibitors seprately from errors on stdout (oamg#620) - Show progress in non verbose executions (oamg#621) ### Known issue - The answerfile is not generated on some machines after the run of leapp. Currently it's under investigation and it will be fixed definitely in the next release. ## Leapp ### Fixes - Print message about generated report when `leapp upgrade` ends, as we do for `leapp preupgrade` (oamg#573) ### Enhancements - Add `leapp answer` to answer Dialog questions on CLI (oamg#592) - Add the --no-rhsm option for (pre)upgrade commands (oamg#622) - Display warning when leapp is used in unsupported (devel/testing) mode (oamg#577) - Print errors on stdout in pretty format (oamg#593) - The error messages are part of the preupgrade report - The verbosity options (--verbose | --debug) are available for leapp commands as well ## Snactor ### Fixes ### Enhancements ## stdlib ### Fixes ### Enhancements - Add `stdin` and `encoding` parameters in the run function (oamg#583, oamg#595) ## Modifications - Code is compatible with Python3 pylint

## Packaging - Add BuildRequires on python2-setuptools - Add new dependency on python2-requests - Add unversioned dependency on leapp-repository and provide the leapp-framework capability in python2-leapp (see docs about "new dependency mechanism") (oamg#591) - Move all leapp and snactor files into related rpms instead of python?-leapp (oamg#591) - Remove dependency on Jinja2 ## Framework ### Fixes - Fix json export capabilities using serialization (oamg#598) ### Enhancements - Add the DESKTOP tag for the leapp report (oamg#612) - Dialogs are non-interactive and redesigned significantly; but in beta support (see the known issue) - Introduce DialogModel that could be processed by actors to add related information into the report (oamg#589) - Introduce Workflow API (see the Workflow APIs tutorial) (oamg#618) - Report inhibitors separately from errors on stdout (oamg#620) - Show progress in non-verbose executions (oamg#621) ### Known issue - The answerfile is not generated on some machines after the run of leapp. Currently it's under investigation. ## Leapp ### Fixes - Print message about generated report when `leapp upgrade` ends, as we do for `leapp preupgrade` (oamg#573) ### Enhancements - Add `leapp answer` to answer Dialog questions in CLI (oamg#592) - Add the --no-rhsm option for (pre)upgrade commands (oamg#622) - Add the --enablerepo option for Leapp to use an existing custom yum/dnf repository during the upgrade - Display a warning when leapp is used in an unsupported (devel/testing) mode (oamg#577) - Print errors on stdout in pretty format (oamg#593) - Error messages are now part of the preupgrade report - The verbosity options (--verbose | --debug) are available for leapp commands as well ## stdlib ### Enhancements - Add `stdin` and `encoding` parameters in the run function (oamg#583, oamg#595) ## Modifications - Code is compatible with Python3 pylint

## Packaging - Add BuildRequires on python2-setuptools - Add new dependency on python2-requests - Add unversioned dependency on leapp-repository and provide the leapp-framework capability in python2-leapp (see docs about "new dependency mechanism") (#591) - Move all leapp and snactor files into related rpms instead of python?-leapp (#591) - Remove dependency on Jinja2 ## Framework ### Fixes - Fix json export capabilities using serialization (#598) ### Enhancements - Add the DESKTOP tag for the leapp report (#612) - Dialogs are non-interactive and redesigned significantly; but in beta support (see the known issue) - Introduce DialogModel that could be processed by actors to add related information into the report (#589) - Introduce Workflow API (see the Workflow APIs tutorial) (#618) - Report inhibitors separately from errors on stdout (#620) - Show progress in non-verbose executions (#621) ### Known issue - The answerfile is not generated on some machines after the run of leapp. Currently it's under investigation. ## Leapp ### Fixes - Print message about generated report when `leapp upgrade` ends, as we do for `leapp preupgrade` (#573) ### Enhancements - Add `leapp answer` to answer Dialog questions in CLI (#592) - Add the --no-rhsm option for (pre)upgrade commands (#622) - Add the --enablerepo option for Leapp to use an existing custom yum/dnf repository during the upgrade - Display a warning when leapp is used in an unsupported (devel/testing) mode (#577) - Print errors on stdout in pretty format (#593) - Error messages are now part of the preupgrade report - The verbosity options (--verbose | --debug) are available for leapp commands as well ## stdlib ### Enhancements - Add `stdin` and `encoding` parameters in the run function (#583, #595) ## Modifications - Code is compatible with Python3 pylint

pirat89 requested review from a team, Rezney, bocekm, fernflower, shaded-enmity and vinzenz January 8, 2020 15:50

pirat89 changed the title ~~[DO_NOT_MERGE] Pkg version deps~~ [DO_NOT_MERGE] packaging: improve deps, polish spec and fix split of files Jan 8, 2020

pirat89 changed the title ~~[DO_NOT_MERGE] packaging: improve deps, polish spec and fix split of files~~ [WIP] packaging: improve deps, polish spec and fix split of files Jan 8, 2020

pirat89 added the wip label Jan 8, 2020

pirat89 mentioned this pull request Jan 8, 2020

packaging: add deps on leapp-framework capability oamg/leapp-repository#429

Merged

drehak reviewed Jan 27, 2020

View reviewed changes

drehak previously approved these changes Jan 30, 2020

View reviewed changes

pirat89 changed the title ~~[WIP] packaging: improve deps, polish spec and fix split of files~~ packaging: improve deps, polish spec and fix split of files Feb 4, 2020

pirat89 removed the wip label Feb 4, 2020

bocekm previously approved these changes Feb 12, 2020

View reviewed changes

pirat89 dismissed stale reviews from bocekm and drehak via f4031af February 12, 2020 19:08

pirat89 force-pushed the pkg_version_deps branch from e749726 to f4031af Compare February 12, 2020 19:08

pirat89 added 3 commits February 12, 2020 21:04

packaging: fix split of files between rpms for py2

136fa36

Move all leapp and snactor files into related rpms instead of keeping them inside the python?-leapp (framework) rpms.

pirat89 force-pushed the pkg_version_deps branch from f4031af to 7f3e84f Compare February 12, 2020 20:08

bocekm approved these changes Feb 12, 2020

View reviewed changes

bocekm merged commit 989f8d7 into oamg:master Feb 12, 2020

pirat89 mentioned this pull request Apr 16, 2020

Release 0.10.0 #624

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

packaging: improve deps, polish spec and fix split of files #591

packaging: improve deps, polish spec and fix split of files #591

Uh oh!

pirat89 commented Jan 8, 2020 •

edited

Loading

Uh oh!

centos-ci commented Jan 8, 2020

Uh oh!

pirat89 commented Jan 8, 2020

Uh oh!

pirat89 commented Jan 8, 2020

Uh oh!

drehak commented Jan 23, 2020

Uh oh!

pirat89 commented Jan 24, 2020

Uh oh!

drehak left a comment

Uh oh!

pirat89 commented Feb 4, 2020

Uh oh!

pirat89 commented Feb 12, 2020 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

packaging: improve deps, polish spec and fix split of files #591

packaging: improve deps, polish spec and fix split of files #591

Uh oh!

Conversation

pirat89 commented Jan 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Tasks:

Uh oh!

centos-ci commented Jan 8, 2020

Uh oh!

pirat89 commented Jan 8, 2020

Uh oh!

pirat89 commented Jan 8, 2020

Uh oh!

drehak commented Jan 23, 2020

Uh oh!

pirat89 commented Jan 24, 2020

Uh oh!

drehak left a comment

Choose a reason for hiding this comment

Uh oh!

pirat89 commented Feb 4, 2020

Uh oh!

pirat89 commented Feb 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pirat89 commented Jan 8, 2020 •

edited

Loading

pirat89 commented Feb 12, 2020 •

edited

Loading