Fixed json export capabilities using serialization #598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbbd9ad to
557c5dd
Compare
fernflower
previously approved these changes
Jan 29, 2020
Member
|
Can you please rebase? |
fernflower
reviewed
Jan 30, 2020
leapp/repository/__init__.py
Outdated
| from leapp.models import resolve_model_references | ||
| import leapp.workflows | ||
| from leapp.repository.definition import DefinitionKind | ||
| from leapp.models import get_models |
leapp/repository/__init__.py
Outdated
| import leapp.libraries.common # noqa # pylint: disable=unused-import | ||
| import leapp.libraries.common # noqa # pylint: disable=unused-import | ||
| from leapp.models import resolve_model_references | ||
| import leapp.workflows |
Previously the serialization feature wasn't fully functionally implemented. This PR is fixing up the missing parts and unifies dump vs serialize naming. The code has been tested in conjunction with the dashboard development.
557c5dd to
15a8b3b
Compare
fernflower
approved these changes
Jan 30, 2020
pirat89
added a commit
to pirat89/leapp
that referenced
this pull request
Apr 7, 2020
## Packaging - Add BuildRequires on python2-setuptools - Add new dependency on python?-requests - Add unversioned dependency on leapp-repository and provide the leapp-framework capability in python2-leapp (see docs about "new dependency mechanism") (oamg#591) - Move all leapp and snactor files into related rpms istead of python?-leapp (oamg#591) - Remove dependency on Jinja2 ## Framework ### Fixes - Fix json export capabilities using serialization (oamg#598) ### Enhancements - Add the DESKTOP tag for the leapp report (oamg#612) - Dialogs are non-interactive and redesigned significantly; but in beta support (see the known issue) - Introduce DialogModel that could be processed by actors to add related information into the report (oamg#589) - Introduce Workflow API (see the tutorial) (oamg#618) - Report inhibitors seprately from errors on stdout (oamg#620) - Show progress in non verbose executions (oamg#621) ### Known issue - The answerfile is not generated on some machines after the run of leapp. Currently it's under investigation and it will be fixed definitely in the next release. ## Leapp ### Fixes - Print message about generated report when `leapp upgrade` ends, as we do for `leapp preupgrade` (oamg#573) ### Enhancements - Add `leapp answer` to answer Dialog questions on CLI (oamg#592) - Add the --no-rhsm option for (pre)upgrade commands (oamg#622) - Display warning when leapp is used in unsupported (devel/testing) mode (oamg#577) - Print errors on stdout in pretty format (oamg#593) - The error messages are part of the preupgrade report - The verbosity options (--verbose | --debug) are available for leapp commands as well ## Snactor ### Fixes ### Enhancements ## stdlib ### Fixes ### Enhancements - Add `stdin` and `encoding` parameters in the run function (oamg#583, oamg#595) ## Modifications - Code is compatible with Python3 pylint
pirat89
added a commit
to pirat89/leapp
that referenced
this pull request
Apr 16, 2020
## Packaging - Add BuildRequires on python2-setuptools - Add new dependency on python2-requests - Add unversioned dependency on leapp-repository and provide the leapp-framework capability in python2-leapp (see docs about "new dependency mechanism") (oamg#591) - Move all leapp and snactor files into related rpms instead of python?-leapp (oamg#591) - Remove dependency on Jinja2 ## Framework ### Fixes - Fix json export capabilities using serialization (oamg#598) ### Enhancements - Add the DESKTOP tag for the leapp report (oamg#612) - Dialogs are non-interactive and redesigned significantly; but in beta support (see the known issue) - Introduce DialogModel that could be processed by actors to add related information into the report (oamg#589) - Introduce Workflow API (see the Workflow APIs tutorial) (oamg#618) - Report inhibitors separately from errors on stdout (oamg#620) - Show progress in non-verbose executions (oamg#621) ### Known issue - The answerfile is not generated on some machines after the run of leapp. Currently it's under investigation. ## Leapp ### Fixes - Print message about generated report when `leapp upgrade` ends, as we do for `leapp preupgrade` (oamg#573) ### Enhancements - Add `leapp answer` to answer Dialog questions in CLI (oamg#592) - Add the --no-rhsm option for (pre)upgrade commands (oamg#622) - Add the --enablerepo option for Leapp to use an existing custom yum/dnf repository during the upgrade - Display a warning when leapp is used in an unsupported (devel/testing) mode (oamg#577) - Print errors on stdout in pretty format (oamg#593) - Error messages are now part of the preupgrade report - The verbosity options (--verbose | --debug) are available for leapp commands as well ## stdlib ### Enhancements - Add `stdin` and `encoding` parameters in the run function (oamg#583, oamg#595) ## Modifications - Code is compatible with Python3 pylint
Merged
pirat89
added a commit
that referenced
this pull request
Apr 16, 2020
## Packaging - Add BuildRequires on python2-setuptools - Add new dependency on python2-requests - Add unversioned dependency on leapp-repository and provide the leapp-framework capability in python2-leapp (see docs about "new dependency mechanism") (#591) - Move all leapp and snactor files into related rpms instead of python?-leapp (#591) - Remove dependency on Jinja2 ## Framework ### Fixes - Fix json export capabilities using serialization (#598) ### Enhancements - Add the DESKTOP tag for the leapp report (#612) - Dialogs are non-interactive and redesigned significantly; but in beta support (see the known issue) - Introduce DialogModel that could be processed by actors to add related information into the report (#589) - Introduce Workflow API (see the Workflow APIs tutorial) (#618) - Report inhibitors separately from errors on stdout (#620) - Show progress in non-verbose executions (#621) ### Known issue - The answerfile is not generated on some machines after the run of leapp. Currently it's under investigation. ## Leapp ### Fixes - Print message about generated report when `leapp upgrade` ends, as we do for `leapp preupgrade` (#573) ### Enhancements - Add `leapp answer` to answer Dialog questions in CLI (#592) - Add the --no-rhsm option for (pre)upgrade commands (#622) - Add the --enablerepo option for Leapp to use an existing custom yum/dnf repository during the upgrade - Display a warning when leapp is used in an unsupported (devel/testing) mode (#577) - Print errors on stdout in pretty format (#593) - Error messages are now part of the preupgrade report - The verbosity options (--verbose | --debug) are available for leapp commands as well ## stdlib ### Enhancements - Add `stdin` and `encoding` parameters in the run function (#583, #595) ## Modifications - Code is compatible with Python3 pylint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the serialization feature wasn't fully functionally implemented.
This PR is fixing up the missing parts.
The code has been tested in conjunction with the dashboard development.