v0.2.1 proposal #58
Merged
v0.2.1 proposal #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this avoids exposing secrets in Docker containers
otherwise nicegui fails to run and the `odtp dashboard` command does not work
that way the docker-compose file can be filled with the secrets on docker compose up the configurations can be checked with `docker compose config`
provide two example `.env` files: one for local setup and one for the docker compose setup
the data that is loaded there is outdated
use mongodb function for the setup and remove mongodb class
these functions are not used any more
igonre .env.compose, ignoring odtpDB.json is no longer needed
since it has been replaced by compose.yml
in order to combine compose.yml with environment variables a `.env` is needed. See here for an explanation: https://stackoverflow.com/questions/48495663/docker-compose-env-file-not-working
fix(Dockerfile): don't expose environment variables
Functional docker compose for all services in ODTP
sabinem
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @sabinem, I'm proposing to include all the modifications we just did in this minor versioning so we can refer to it on the documentation. What do you think?