Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Deprecate Python 3.7 due to EOL #5191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
May 15, 2023
Merged

Deprecate Python 3.7 due to EOL #5191

merged 18 commits into from
May 15, 2023

Conversation

@jcwchen
Copy link
Member

@jcwchen jcwchen commented May 2, 2023 •
edited
Loading

Description

  • Deprecate Python 3.7 due to EOL.
  • Use pip install -e . instead of python setup.py install in CIs, because it is the suggested way to develop onnx mentioned in README.md.
  • Set correct permission for clang-tidy.
  • Remove dependency: typing_extensions entirely, because starting Python 3.8, native typing support Literal and Protocol.

Motivation and Context

@jcwchen jcwchen added topic: build Issues related to ONNX builds and packages module: CI pipelines Issues related to the CI pipeline run release CIs Use this label to trigger release tests in CI labels May 2, 2023
@jcwchen jcwchen requested review from a team as code owners May 2, 2023 14:39
@justinchuby
Copy link
Member

I would also update this line

onnx/pyproject.toml

Line 64 in a550a45

target-version = "py37"

jcwchen added 2 commits May 2, 2023 09:14
@jcwchen
upgrade setuptools
87f6749 
Signed-off-by: Chun-Wei Chen <[email protected]>
@jcwchen
fix lint
87acec3 
Signed-off-by: Chun-Wei Chen <[email protected]>
@jcwchen jcwchen removed the run release CIs Use this label to trigger release tests in CI label May 3, 2023
jcwchen added 2 commits May 3, 2023 10:48
@jcwchen
pip install -e .
ee718ff 
Signed-off-by: Chun-Wei Chen <[email protected]>
@jcwchen
fix lint
f08e180 
Signed-off-by: Chun-Wei Chen <[email protected]>
@andembry andembry mentioned this pull request May 3, 2023
Merged
@jcwchen
pytest first
7d7001b 
Signed-off-by: Chun-Wei Chen <[email protected]>
@jcwchen jcwchen added the run release CIs Use this label to trigger release tests in CI label May 3, 2023
xadupre
xadupre reviewed May 10, 2023
View reviewed changes
@jcwchen jcwchen added the dependencies Pull requests that update a dependency file label May 15, 2023
@jcwchen jcwchen requested a review from xadupre May 15, 2023 20:23
@jcwchen
Copy link
Member Author

jcwchen commented May 15, 2023

Please note that this PR also removes a dependency: typing_extensions entirely, because starting Python 3.8, native typing support Literal and Protocol.

@jcwchen jcwchen merged commit ae003b9 into onnx:main May 15, 2023
q-ycong-p pushed a commit to q-ycong-p/onnx that referenced this pull request May 18, 2023
@jcwchen
Deprecate Python 3.7 due to EOL (onnx#5191)
609f872 
Signed-off-by: Chun-Wei Chen <[email protected]>
Signed-off-by: Yu Cong <[email protected]>
@hamptonm1 hamptonm1 mentioned this pull request Jun 1, 2023
Closed
adityagoel4512 pushed a commit to adityagoel4512/onnx that referenced this pull request Jul 28, 2023
@jcwchen @adityagoel4512
Deprecate Python 3.7 due to EOL (onnx#5191)
47e6734 
Signed-off-by: Chun-Wei Chen <[email protected]>
Signed-off-by: Aditya Goel <[email protected]>
@jcwchen jcwchen mentioned this pull request Sep 21, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinchuby justinchuby justinchuby left review comments

@liqunfu liqunfu liqunfu approved these changes

@gramalingam gramalingam gramalingam approved these changes

@xadupre xadupre Awaiting requested review from xadupre

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file module: CI pipelines Issues related to the CI pipeline run release CIs Use this label to trigger release tests in CI topic: build Issues related to ONNX builds and packages

Projects

PR Tracker
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Tracking] Deprecate Python 3.7 due to EOL [Tracking] Release CI for aarch64 fails due to the latest qemu docker image

5 participants

@jcwchen @justinchuby @liqunfu @gramalingam @xadupre