Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Deprecate all type casting functions #6639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jan 22, 2025
Merged

Deprecate all type casting functions #6639

merged 11 commits into from
Jan 22, 2025

Conversation

@justinchuby
Copy link
Member

@justinchuby justinchuby commented Jan 11, 2025 •
edited
Loading

Deprecate all type casting functions because they are mere utilities or reference implementations that should not be directly exposed to users. Users should leverage libraries like ml_dtypes for type conversion.

  • Additionally turned convert_endian and split_complex_to_pairs into private. This is seen as low risk.
  • Added typing_extensions as a dependency. This is a common dependency used by python packages as a polyfill for the typing module.

@justinchuby justinchuby added this to the 1.18 milestone Jan 11, 2025
@codecov
Copy link

codecov bot commented Jan 11, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 84.37500% with 10 lines in your changes missing coverage. Please review.

Project coverage is 57.50%. Comparing base (8275472) to head (390517c).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
onnx/subbyte.py 86.20% 4 Missing ⚠️
onnx/helper.py 88.00% 3 Missing ⚠️
onnx/numpy_helper.py 70.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6639      +/-   ##
==========================================
+ Coverage   57.46%   57.50%   +0.03%     
==========================================
  Files         507      507              
  Lines       31584    31624      +40     
  Branches     3046     3046              
==========================================
+ Hits        18151    18185      +34     
- Misses      12607    12613       +6     
  Partials      826      826

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 11, 2025
View reviewed changes
@justinchuby justinchuby mentioned this pull request Jan 13, 2025
Merged
@justinchuby justinchuby added the release notes Important changes to call out in release notes label Jan 14, 2025
@justinchuby justinchuby temporarily deployed to testpypi_onnxweekly January 14, 2025 01:06 — with GitHub Actions Inactive
github-merge-queue bot pushed a commit that referenced this pull request Jan 14, 2025
@justinchuby
Fix numpy_helper to_array (#6638)
8275472 
### Description

Refactor `to_array` to simplify and fix conversion logic.

- The `_to_array` function was renamed back to `to_array`, consolidating
with existing logic that leverages custom dtypes.
- Created an unpack_4bit helper to unpack packed 4bit dtype data,
replacing usage of the 4bit->float32 conversion functions because the
original logic was not actually needed.
- Removed test skips because bugs were fixed.
- Type casting functions for custom dtypes will be marked private in the
next PR. Public versions of them will be scheduled for deprecation.
(#6639) Users should use other libraries like ml_dtypes for efficient
type conversion in numpy.

### Motivation and Context

Fix #6604

---------

Signed-off-by: Justin Chu <[email protected]>
@justinchuby justinchuby marked this pull request as ready for review January 14, 2025 19:50
@justinchuby justinchuby requested a review from a team as a code owner January 14, 2025 19:50
@justinchuby
wording
04fa6bc 
Signed-off-by: Justin Chu <[email protected]>
@justinchuby
docs
8b08853 
Signed-off-by: Justin Chu <[email protected]>
@justinchuby
Endian
f353697 
Signed-off-by: Justin Chu <[email protected]>
@justinchuby
Update requirements.txt
93ea4ae 
Signed-off-by: Justin Chu <[email protected]>
@justinchuby
revert
390517c 
Signed-off-by: Justin Chu <[email protected]>
@justinchuby justinchuby added the run release CIs Use this label to trigger release tests in CI label Jan 14, 2025
@justinchuby justinchuby temporarily deployed to testpypi_onnxweekly January 14, 2025 22:06 — with GitHub Actions Inactive
@justinchuby justinchuby enabled auto-merge January 14, 2025 23:54
shubhambhokare1
shubhambhokare1 approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@shubhambhokare1 shubhambhokare1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinchuby
Copy link
Member Author

@gramalingam for approval. Thanks!

@justinchuby justinchuby temporarily deployed to testpypi_onnxweekly January 22, 2025 15:01 — with GitHub Actions Inactive
@justinchuby justinchuby temporarily deployed to testpypi_onnxweekly January 22, 2025 15:18 — with GitHub Actions Inactive
@justinchuby justinchuby added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit bcecb8c Jan 22, 2025
116 of 154 checks passed
@justinchuby justinchuby deleted the justinchu/deprecation branch January 22, 2025 20:11
titaiwangms pushed a commit to titaiwangms/onnx that referenced this pull request Jan 22, 2025
@justinchuby @titaiwangms
Deprecate all type casting functions (onnx#6639)
1424dd7 
Deprecate all type casting functions because they are mere utilities or
reference implementations that should not be directly exposed to users.
Users should leverage libraries like `ml_dtypes` for type conversion.

- Additionally turned convert_endian and split_complex_to_pairs into
private. This is seen as low risk.
- Added typing_extensions as a dependency. This is a common dependency
used by python packages as a polyfill for the typing module.

---------

Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: titaiwangms <[email protected]>
titaiwangms pushed a commit to titaiwangms/onnx that referenced this pull request Jan 23, 2025
@justinchuby @titaiwangms
Deprecate all type casting functions (onnx#6639)
904b525 
Deprecate all type casting functions because they are mere utilities or
reference implementations that should not be directly exposed to users.
Users should leverage libraries like `ml_dtypes` for type conversion.

- Additionally turned convert_endian and split_complex_to_pairs into
private. This is seen as low risk.
- Added typing_extensions as a dependency. This is a common dependency
used by python packages as a polyfill for the typing module.

---------

Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: titaiwangms <[email protected]>
titaiwangms pushed a commit to titaiwangms/onnx that referenced this pull request Jan 23, 2025
@justinchuby @titaiwangms
Deprecate all type casting functions (onnx#6639)
ef89f27 
Deprecate all type casting functions because they are mere utilities or
reference implementations that should not be directly exposed to users.
Users should leverage libraries like `ml_dtypes` for type conversion.

- Additionally turned convert_endian and split_complex_to_pairs into
private. This is seen as low risk.
- Added typing_extensions as a dependency. This is a common dependency
used by python packages as a polyfill for the typing module.

---------

Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: titaiwangms <[email protected]>
titaiwangms pushed a commit to titaiwangms/onnx that referenced this pull request Jan 23, 2025
@justinchuby @titaiwangms
Deprecate all type casting functions (onnx#6639)
8564478 
Deprecate all type casting functions because they are mere utilities or
reference implementations that should not be directly exposed to users.
Users should leverage libraries like `ml_dtypes` for type conversion.

- Additionally turned convert_endian and split_complex_to_pairs into
private. This is seen as low risk.
- Added typing_extensions as a dependency. This is a common dependency
used by python packages as a polyfill for the typing module.

---------

Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: titaiwangms <[email protected]>
titaiwangms pushed a commit to titaiwangms/onnx that referenced this pull request Jan 24, 2025
@justinchuby @titaiwangms
Deprecate all type casting functions (onnx#6639)
82685b2 
Deprecate all type casting functions because they are mere utilities or
reference implementations that should not be directly exposed to users.
Users should leverage libraries like `ml_dtypes` for type conversion.

- Additionally turned convert_endian and split_complex_to_pairs into
private. This is seen as low risk.
- Added typing_extensions as a dependency. This is a common dependency
used by python packages as a polyfill for the typing module.

---------

Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: titaiwangms <[email protected]>
@justinchuby justinchuby mentioned this pull request Jan 24, 2025
Closed
andife pushed a commit that referenced this pull request Jan 25, 2025
@justinchuby @andife
Fix numpy_helper to_array (#6638)
d94bf71 
### Description

Refactor `to_array` to simplify and fix conversion logic.

- The `_to_array` function was renamed back to `to_array`, consolidating
with existing logic that leverages custom dtypes.
- Created an unpack_4bit helper to unpack packed 4bit dtype data,
replacing usage of the 4bit->float32 conversion functions because the
original logic was not actually needed.
- Removed test skips because bugs were fixed.
- Type casting functions for custom dtypes will be marked private in the
next PR. Public versions of them will be scheduled for deprecation.
(#6639) Users should use other libraries like ml_dtypes for efficient
type conversion in numpy.

### Motivation and Context

Fix #6604

---------

Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Andreas Fehlner <[email protected]>
andife pushed a commit that referenced this pull request Jan 25, 2025
@justinchuby @andife
Deprecate all type casting functions (#6639)
6a0b2ca 
Deprecate all type casting functions because they are mere utilities or
reference implementations that should not be directly exposed to users.
Users should leverage libraries like `ml_dtypes` for type conversion.

- Additionally turned convert_endian and split_complex_to_pairs into
private. This is seen as low risk.
- Added typing_extensions as a dependency. This is a common dependency
used by python packages as a polyfill for the typing module.

---------

Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Andreas Fehlner <[email protected]>
seungwoo-ji-03 pushed a commit to seungwoo-ji-03/onnx that referenced this pull request Feb 17, 2025
@justinchuby
Fix numpy_helper to_array (onnx#6638)
c3e1cf1 
### Description

Refactor `to_array` to simplify and fix conversion logic.

- The `_to_array` function was renamed back to `to_array`, consolidating
with existing logic that leverages custom dtypes.
- Created an unpack_4bit helper to unpack packed 4bit dtype data,
replacing usage of the 4bit->float32 conversion functions because the
original logic was not actually needed.
- Removed test skips because bugs were fixed.
- Type casting functions for custom dtypes will be marked private in the
next PR. Public versions of them will be scheduled for deprecation.
(onnx#6639) Users should use other libraries like ml_dtypes for efficient
type conversion in numpy.

### Motivation and Context

Fix onnx#6604

---------

Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: seungwoo-ji <[email protected]>
seungwoo-ji-03 pushed a commit to seungwoo-ji-03/onnx that referenced this pull request Feb 17, 2025
@justinchuby
Deprecate all type casting functions (onnx#6639)
1aa9294 
Deprecate all type casting functions because they are mere utilities or
reference implementations that should not be directly exposed to users.
Users should leverage libraries like `ml_dtypes` for type conversion.

- Additionally turned convert_endian and split_complex_to_pairs into
private. This is seen as low risk.
- Added typing_extensions as a dependency. This is a common dependency
used by python packages as a polyfill for the typing module.

---------

Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: seungwoo-ji <[email protected]>
@botantony botantony mentioned this pull request May 14, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gramalingam gramalingam gramalingam approved these changes

+1 more reviewer

@shubhambhokare1 shubhambhokare1 shubhambhokare1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

module: utility Helper modules release notes Important changes to call out in release notes run release CIs Use this label to trigger release tests in CI topic: deprecation

Projects

PR Tracker
Status: Done

Milestone

1.18

Development

Successfully merging this pull request may close these issues.

3 participants

@justinchuby @gramalingam @shubhambhokare1