-
Notifications
You must be signed in to change notification settings - Fork 840
Adding Support for Sdtrig Extension in CVA6 #3097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
munailwaqar
wants to merge
19
commits into
openhwgroup:master
Choose a base branch
from
10x-Engineers:triggers-upstream
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ failed run, report available here. |
05ab967
to
0f58810
Compare
❌ failed run, report available here. |
@JeanRochCoulon Hi, I see that the GitHub CI is passing on my latest commit but the Thales CI is reported as failing. However, I can not see the latest Thales report/logs. It still shows the old commit reports. Can you please look into this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This PR adds support for the Sdtrig Extension in CVA6, which primarily adds the Trigger Module. The core can now support four types of triggers i.e. icount, mcontrol6, etrigger and itrigger.
Implementation
The number of triggers supported by the core is parameterized and can be set at compile time.
The trigger module supports 2 types of action on trigger match i.e. breakpoint exception generation and debug mode
Modifications
The entire Trigger Module has been added under a SDTRIG bit for configuration. Additionally, all trigger types can be individually enabled and disabled using their own dedicated bits Icount, Mcontrol6, Etrigger, Itrigger.
The new trigger_module (trigger_module.sv) was added inside the CSR Register File (csr_regfile.sv). Additionally, the csr_regfile, commit stage and decode modules were updated to handle trigger fire logic.
Modifications Diagram

Documentation and Reference
The official The RISC-V Debug Specification Version 1.0.0 was followed to ensure alignment with ratification.
Verification
These changes have been tested with self-written tests to ensure proper functionality.