Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@jhusak
Copy link
Contributor

@jhusak jhusak commented Nov 30, 2023

I have added the commandline arg: -Hdevicename , for example -Hdevicename D - which let me run a game that is a DOS dependent without DOS.
Only first non-space character will be a device name.
However, there is completely no checking what user entered. But the same is in other options, so I let it stay like that. In case the device exists in HATABS, the duplicate will be added.

In the future, an option in menu may be added.

src/devices.c Outdated
Log_print("\t-H3 <path> Set path for H3: device");
Log_print("\t-H4 <path> Set path for H4: device");
Log_print("\t-Hpath <path> Set path for Atari executables on the H: device");
Log_print("\t-Hdevicename <X> Rename H: device for something different");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, a better description could be like "Use this letter to access the Host device, instead of H:".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.

Copy link
Contributor Author

@jhusak jhusak Dec 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How to do this best? As second commit or create new pull request with one commit? I am a kind of new in PullRequesting - what is the procedure with PR which have to be changed/fixed?

@mikrosk
Copy link
Member

mikrosk commented Dec 1, 2023

In the future, an option in menu may be added.

@joysfera what is (was :)) the policy for adding command line parameters? Does every parameter have to an UI counterpart or it is OK to introduce standalone command line switches?

@jhusak
Copy link
Contributor Author

jhusak commented Dec 1, 2023

However, I have commited this change. If I have to make this one commit, write me please. The second option is to squash two commits, but I do not have Github Desktop.

@mikrosk
Copy link
Member

mikrosk commented Dec 1, 2023

Don't worry, push as many commits as you like. I'll squash it by merging.

@jhusak
Copy link
Contributor Author

jhusak commented Dec 1, 2023

ok, thanks, it makes things much simplier :) The PR is ready :)

@jhusak
Copy link
Contributor Author

jhusak commented Dec 1, 2023

Well next PR is waiting (cleanup rather)...

@mikrosk mikrosk merged commit 314fc2e into atari800:master Dec 1, 2023
@joysfera
Copy link
Member

joysfera commented Dec 4, 2023

@mikrosk it's indeed better when a new feature comes with UI setting as well. But in this case we might want to test this from command line before bothering with UI refactoring, to find out how useful it is.

@jhusak
Copy link
Contributor Author

jhusak commented Dec 4, 2023

BTW, the menu is hard to develop. That stopped me to do the menu entry for this option; I was afraid I'd miss something.
And I needed it asap, so that was a good start to check if this is valuable and usable for people (I think: yes, it is)
I'll think about changing the menu structure to more struct-driven than code-driven. Once I have done this for microcontrollers and LCD.

@jhusak
Copy link
Contributor Author

jhusak commented Dec 6, 2023

About settings H: rename I propose such solution:
The line:
"H: device (hard disk)"
change to:
"Hard disk device (:)" , eventually ": device (hard disk)"

Lines H1:...H4: rename so dynamically

and everywhere H: is mentioned , renamed letter should appear.

In advanced options add line:
Use hard disk device as '<letter'.

When pressed, add requester with a letter to enter from keyboard (or a mesh with all A-Z letters?)

What do you think?

@mikrosk
Copy link
Member

mikrosk commented Dec 7, 2023

@jhusak I think entering the letter is sufficient, I guess everyone knows the alphabet. ;-)

The H: options could use some cleanup. I'd put everything into "Hard disk options". Then you could have:

  • Hard disk device: H (changed after clicking)
  • Device state: disabled / ro / rw
  • Atari executables path
  • x1 ... x4 clickable paths (no idea why these are duplicated in the advanced options and not even clickable)
  • is that "currently open files" good for something?

@jhusak
Copy link
Contributor Author

jhusak commented Dec 7, 2023

It is rather not to enter !@#$%& as device "letters".

@dmsc
Copy link
Contributor

dmsc commented Dec 8, 2023

Hi!

I created a pull request with a proposed new menu arrangement.

@jhusak I think entering the letter is sufficient, I guess everyone knows the alphabet. ;-)

Instead, I implemented that each click advances the current letter, avoiding "C", "E", "K" and "S". It
is simpler to implement and fast for the user.

The H: options could use some cleanup. I'd put everything into "Hard disk options". Then you could have:

I also renamed "hard disk" to "host device". IMHO, this makes sense, as nobody actually uses hard-disks
as "H:" in real Atari, and the functionality actually exports "host" files to the emulator.

  • Hard disk device: H (changed after clicking)
  • Device state: disabled / ro / rw

I put the enable/disable first, because the other options "depend" on it.

  • Atari executables path
  • x1 ... x4 clickable paths (no idea why these are duplicated in the advanced options and not even clickable)

Those are the current working directory in each of the emulated devices.

  • is that "currently open files" good for something?

I renamed the menu to "status", as those are actually the status of the H devices.

Have Fun!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants