-
Notifications
You must be signed in to change notification settings - Fork 106
Added H: device rename; save it in setup file #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/devices.c
Outdated
| Log_print("\t-H3 <path> Set path for H3: device"); | ||
| Log_print("\t-H4 <path> Set path for H4: device"); | ||
| Log_print("\t-Hpath <path> Set path for Atari executables on the H: device"); | ||
| Log_print("\t-Hdevicename <X> Rename H: device for something different"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, a better description could be like "Use this letter to access the Host device, instead of H:".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How to do this best? As second commit or create new pull request with one commit? I am a kind of new in PullRequesting - what is the procedure with PR which have to be changed/fixed?
@joysfera what is (was :)) the policy for adding command line parameters? Does every parameter have to an UI counterpart or it is OK to introduce standalone command line switches? |
|
However, I have commited this change. If I have to make this one commit, write me please. The second option is to squash two commits, but I do not have Github Desktop. |
|
Don't worry, push as many commits as you like. I'll squash it by merging. |
|
ok, thanks, it makes things much simplier :) The PR is ready :) |
|
Well next PR is waiting (cleanup rather)... |
|
@mikrosk it's indeed better when a new feature comes with UI setting as well. But in this case we might want to test this from command line before bothering with UI refactoring, to find out how useful it is. |
|
BTW, the menu is hard to develop. That stopped me to do the menu entry for this option; I was afraid I'd miss something. |
|
About settings H: rename I propose such solution: Lines H1:...H4: rename so dynamically and everywhere H: is mentioned , renamed letter should appear. In advanced options add line: When pressed, add requester with a letter to enter from keyboard (or a mesh with all A-Z letters?) What do you think? |
|
@jhusak I think entering the letter is sufficient, I guess everyone knows the alphabet. ;-) The H: options could use some cleanup. I'd put everything into "Hard disk options". Then you could have:
|
|
It is rather not to enter !@#$%& as device "letters". |
|
Hi! I created a pull request with a proposed new menu arrangement.
Instead, I implemented that each click advances the current letter, avoiding "C", "E", "K" and "S". It
I also renamed "hard disk" to "host device". IMHO, this makes sense, as nobody actually uses hard-disks
I put the enable/disable first, because the other options "depend" on it.
Those are the current working directory in each of the emulated devices.
I renamed the menu to "status", as those are actually the status of the H devices. Have Fun! |
I have added the commandline arg: -Hdevicename , for example -Hdevicename D - which let me run a game that is a DOS dependent without DOS.
Only first non-space character will be a device name.
However, there is completely no checking what user entered. But the same is in other options, so I let it stay like that. In case the device exists in HATABS, the duplicate will be added.
In the future, an option in menu may be added.