Thanks! At a first glance it looks good, I'll take a look later today.

@joysfera ah, so this what you meant. You kept this one open intentionally and not merged it into the 5.1.0 release. As far as I'm concerned, you could have merged it. Maybe you can do a quick 5.1.1 release. :)

It makes sense to have this and #204 together.

@dmsc since it has not been merged yet (I apologise for my slow response) I have a few suggestions:

• the way how user selects the H: (etc) letter is quite irritating when you miss "your" letter: you have to go through the whole alphabet again. I'd suggest to either list all letters in as a combo box or to allow the user to enter the letter and do some validation (i.e. just A-Z)
• the H: section takes way too much space. I think it's better to put it under one menu item and then list all of the sub-items. This feature isn't so widely used, there's no need for it to take 1/3 of the screen space
• is that "Current directories:" really needed? What is it good for? Why not just show the mapped paths?

Other than that, I like it, very nice cleanup.

I'll give @dmsc few days to see if he can incorporate your suggestions.

Hi!

@dmsc since it has not been merged yet (I apologise for my slow response) I have a few suggestions:

• the way how user selects the H: (etc) letter is quite irritating when you miss "your" letter: you have to go through the whole alphabet again. I'd suggest to either list all letters in as a combo box or to allow the user to enter the letter and do some validation (i.e. just A-Z)

Will try to implement something, the UI stuff is not that advanced....

• the H: section takes way too much space. I think it's better to put it under one menu item and then list all of the sub-items. This feature isn't so widely used, there's no need for it to take 1/3 of the screen space

I will put all the options in the current "advanced" sub-menu.

• is that "Current directories:" really needed? What is it good for? Why not just show the mapped paths?

Don't know if it is useful, I have never used it :-P
It is not the mapped paths, it is the folder inside the path that is currently selected in the emulated Atari.

Other than that, I like it, very nice cleanup.

Ok, will update the pull request in the afternoon.

Have Fun!

done, please review!

@dmsc Looks good, thank you!

Ok, this looks indeed much better. I have noticed only one thing, the input isn't validated. So one can enter drives like 3: or $:. Not a showstopper but should be validated.

I documented in the NEWS file that only letters could be used :-)
Thus I agree we need to add the validation eventually.

Another "prohibited" device letter could be "R:", BTW... I think it's used for networking?

There's more, e.g. P: for host printer. And then of course is the question what happens if you run a cartridge which install T: and you just set your hard drive to be T:.

Hi!

I documented in the NEWS file that only letters could be used :-) Thus I agree we need to add the validation eventually.

Another "prohibited" device letter could be "R:", BTW... I think it's used for networking?

Yes, that was a mistake - I intended to validate to working letters.

I will settle for this list of valid device letter: " A B D F G H I J L M N O Q T U V W X Y Z ".

Ok, created a new pull request.