-
-
Notifications
You must be signed in to change notification settings - Fork 34
Add new tasks and expose them via a CLI #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- adds prepare release task: aurelia#357 - blocked on: aurelia/tools#51
src/index.js
Outdated
| const variations = [ | ||
| { module: "amd" }, | ||
| { module: "commonjs" }, | ||
| { module: "es2015", directory: "native-modules" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can drop the native-modules build, I shouldn't have included it in the first place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we want it for Webpack tree-shaking! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's another directory called es2015 with the same output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, es2015 is es2015 code with es2015 modules.
native-modules is es5 code but with es2015 modules (import/export) retained.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah- I see the distinction now: tsc --outDir dist/native-modules --module es2015 vs tsc --outDir dist/es2015 --target es2015 --module es2015. I think I broke this in the ux build 😬
|
Are we good to go on this? It's not going to break anything is it? |
|
It should be a non-breaking change, just adds features. I still wanted to fix that |
|
Should I merge this and then take another PR for the other changes or do you just want to fix up this PR? |
|
I'll try to fix this up today. Doesn't make sense to release before we have this working properly. |
|
I sent a PR to standard-version to make that tag prefix configurable and they already released it to NPM. Added TODO to first post. |
|
TODO from the first post applies. I didn't have time to finish this yet :(. If somebody else wants to do those two tasks, feel free to take over the PR. |
|
Best I could do is somewhere in the first half of February. |
|
Looks like this is ready now. If you, @EisenbergEffect, have no more remarks, we can merge and release, we can probably bump to v1.1.0, if not even v2.0.0, just cause we had so many new features (even though we shouldn't be breaking anything). |
|
I'd like to see if @jdanyow can make a final review. You two know this better than I do. If you both feel it's good, then I'm happy and we can do a 2.0 release. |
|
@niieani, @jdanyow if you could give some feedback when you have time.
My current working setup uses {
"extends": "./tsconfig.build",
"compilerOptions": {},
"include": [
"./dist/doc-temp/*.d.ts"
],
"exclude": []
}Part of the npm script for the doc task |
|
The related TypeStrong/typedoc#436 was unfortunately closed. I'd say this is still a good start for a unified build/release system. |
|
seems similar to build targets |
|
@jdanyow Do we need this anymore? |
Related to the new build system: aurelia/validation#357
Includes the prepare release task (bump version, changelog).
TODO:
aurelia-toolsneeds to use the new tag prefix option fromstandard-version.index.js