Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Outstanding TODOs from PR #51 #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
niieani merged 4 commits into from
Feb 8, 2017
Merged

Outstanding TODOs from PR #51 #54

niieani merged 4 commits into from
Feb 8, 2017

Conversation

@ckotzbauer
Copy link

@ckotzbauer ckotzbauer commented Feb 6, 2017

  • Updated standard-version to 4.0.0 and set tagPrefix to empty string
  • Extracted cli stuff to own file from index.js

In Addition to #51

@EisenbergEffect @niieani

@EisenbergEffect
Copy link
Contributor

EisenbergEffect commented Feb 7, 2017

@jdanyow @niieani Can one of you guys take a look at this?

niieani
niieani reviewed Feb 8, 2017
View reviewed changes
src/index.js
@@ -1,22 +1,9 @@
#!/usr/bin/env node
"use strict";
Copy link
Contributor

@niieani niieani Feb 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably wanna keep "use strict" here

@niieani niieani merged commit 04f42ed into aurelia:cli Feb 8, 2017
@niieani
Copy link
Contributor

niieani commented Feb 8, 2017

Does this fix the doc building issue on Windows?

@StrahilKazlachev
Copy link

StrahilKazlachev commented Feb 8, 2017 •
edited
Loading

@niieani No, I still get

> aurelia-tools doc-build --continue-when-failed

events.js:160
      throw er; // Unhandled 'error' event
      ^

Error: spawn ./node_modules/.bin/tsc ENOENT
    at exports._errnoException (util.js:1022:11)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:193:32)
    at onErrorNT (internal/child_process.js:359:16)
    at _combinedTickCallback (internal/process/next_tick.js:74:11)
    at process._tickCallback (internal/process/next_tick.js:98:9)
    at Module.runMain (module.js:606:11)
    at run (bootstrap_node.js:394:7)
    at startup (bootstrap_node.js:149:9)
    at bootstrap_node.js:509:3

This line is causing the issue.

EDIT - What I did:

  1. I checked out loader-webpack
  2. npm install
  3. npm run build

@ckotzbauer ckotzbauer deleted the cli branch February 9, 2017 06:43
@ckotzbauer
Copy link
Author

ckotzbauer commented Feb 9, 2017

I can check this today evening

@ckotzbauer
Copy link
Author

ckotzbauer commented Feb 9, 2017 •
edited
Loading

@StrahilKazlachev @niieani
This can be fixed if this line

const tsc = spawn( './node_modules/.bin/tsc', [ '--project', argv.project, '--outFile', path.join(argv.outDir, packageName + '.js') ] );

is replaced with this line:

const tsc = spawn( "node", [ './node_modules/typescript/bin/tsc', '--project', argv.project, '--outFile', path.join(argv.outDir, packageName + '.js') ] );

The typedoc subcommand also has problems, because it only prints the usage docs...

@ckotzbauer
Copy link
Author

ckotzbauer commented Feb 9, 2017

Ok, typedoc seems to have no problems. I used the command in a wrong way. I can submit a PR for the first problem with doc-build, if you want.

@niieani
Copy link
Contributor

niieani commented Feb 9, 2017

@code-chris that would be fantastic. Please target the #cli branch.

@ckotzbauer
Copy link
Author

ckotzbauer commented Feb 9, 2017

@niieani done #56

@StrahilKazlachev
Copy link

StrahilKazlachev commented Feb 9, 2017

@code-chris Nice!
@niieani I had to explicitly install typedoc @ 0.5.1. The implicitly installed 0.5.5 decided that it doesn't like some of the options, it spit:

Usage:
 typedoc --mode modules --out path/to/documentation path/to/sourcefiles
TypeDoc options:
 --disableOutputCheck                Should TypeDoc disable the testing and cleaning of the output directory?
 --entryPoint                        Specifies the fully qualified name of the root symbol. Defaults to global namespace.
 --exclude                           Define a pattern for excluded files when specifying paths.
 --excludeExternals                  Prevent externally resolved TypeScript files from being documented.
 --excludeNotExported                Prevent symbols that are not exported from being documented.
 ... and so on

npm ERR! Windows_NT 10.0.14393
npm ERR! argv "C:\\Program Files\\nodejs\\node.exe" "bla\\bla\\bla\\npm\\node_modules\\npm\\bin\\npm-cli.js" "run" "build:doc"
npm ERR! node v6.9.4
npm ERR! npm  v4.1.2
npm ERR! code ELIFECYCLE
npm ERR! [email protected] build:doc: `aurelia-tools doc-shape-defs && aurelia-tools typedoc`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] build:doc script 'aurelia-tools doc-shape-defs && aurelia-tools typedoc'.

With 0.5.1 the TS just complains Cannot find name 'Promise'., but it finishes.

@niieani
Copy link
Contributor

niieani commented Feb 9, 2017

Hmm, thanks for reporting @StrahilKazlachev. We should probably do something about that. Again, open to PRs with fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdanyow jdanyow Awaiting requested review from jdanyow

1 more reviewer

@niieani niieani niieani left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ckotzbauer @EisenbergEffect @niieani @StrahilKazlachev