Integrate pep484 type hints into chalice #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a stub because I don't want to require the typing module as a runtime dep when invoking lambda functions.
Will need to figure out how to make this work with dev envs (it's assuming you just have mypy installed).
I didn't bother adding type hints to AST visitor, as that code is likely to change soon.
jamesls
pushed a commit
that referenced
this pull request
Jun 29, 2018
* add test for reserved_concurrency * add test for planner * fix parentheses in appending tuple * fix test apicall mismatch * fix function name mismatch * add \n to tested message * change test messages, fix dict reassignment * add type annotation for mypy
jamesls
pushed a commit
that referenced
this pull request
Jul 24, 2020
* small fix to README for what seems like a leftover from a renaming exercise * updating version rst * typo fix
jamesls
added a commit
that referenced
this pull request
May 17, 2022
PR #1928 * eaglepointpartners/master: Add changelog for tf websocket support Revert formating changes Use function name as output for handler names Fixed prchecks (#1) Added tests for websockets_api terraform packaging Removed incorrect comment from TerraformGenerator Fixed terraform package websockets lambda invoke permission resource definition Fixed integration_uri Adds terraform packaging support for websocketapi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the inline type comments to indicate types with the exception of the app.py module. Here I'm using a pyi stub file so we don't take a dependency on typing in the lambda runtime.