Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Feature/configure reserved concurrency #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 29, 2018
Merged

Feature/configure reserved concurrency #875

merged 4 commits into from
Jun 29, 2018

Conversation

@xplorld
Copy link
Contributor

@xplorld xplorld commented Jun 21, 2018

Fix #791

xplorld added 3 commits June 15, 2018 16:41
@xplorld
add reserved_concurrency
07d1e79
@xplorld
add functions to awsclient, and call in planner
d98730b
@xplorld
update test to pass the CI (#1)
0bf75ab 
* add test for reserved_concurrency

* add test for planner

* fix parentheses in appending tuple

* fix test apicall mismatch

* fix function name mismatch

* add \n to tested message

* change test messages, fix dict reassignment

* add type annotation for mypy
@codecov-io
Copy link

codecov-io commented Jun 21, 2018 •
edited
Loading

Codecov Report

Merging #875 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #875      +/-   ##
==========================================
+ Coverage   95.24%   95.27%   +0.02%     
==========================================
  Files          22       22              
  Lines        3976     3998      +22     
  Branches      511      513       +2     
==========================================
+ Hits         3787     3809      +22     
  Misses        122      122              
  Partials       67       67
Impacted Files Coverage Δ
chalice/deploy/deployer.py 98.51% <ø> (ø) ⬆️
chalice/deploy/models.py 99.25% <100%> (ø) ⬆️
chalice/package.py 100% <100%> (ø) ⬆️
chalice/deploy/planner.py 95.45% <100%> (+0.24%) ⬆️
chalice/config.py 98.01% <100%> (+0.02%) ⬆️
chalice/awsclient.py 93.22% <100%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ac65bc...3601101. Read the comment docs.

@jamesls
Copy link
Member

jamesls commented Jun 29, 2018

Awesome! Thanks for the pull request, looking over this now.

jamesls
jamesls approved these changes Jun 29, 2018
View reviewed changes
Copy link
Member

@jamesls jamesls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I made one small change where we don't print out "Update ..." statements when we delete function concurrency. That way if a user never sets this value they won't see "Updating lambda function concurrency" messages. Other looks good to me.

@jamesls jamesls merged commit 3601101 into aws:master Jun 29, 2018
jamesls added a commit that referenced this pull request Jun 29, 2018
@jamesls
Merge branch 'ClarityMovement-feature/configure-reserved-concurrency'
6dd7ab9 
PR #875.

* ClarityMovement-feature/configure-reserved-concurrency:
  Only print update statements on put calls
  add test for awsclient for codecov
  update test to pass the CI (#1)
  add functions to awsclient, and call in planner
  add reserved_concurrency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jamesls jamesls jamesls approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xplorld @codecov-io @jamesls