Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(release): 1.126.0#5029

Merged
mergify[bot] merged 4 commits intoreleasefrom
bump/1.126.0
Jan 26, 2026
Merged

chore(release): 1.126.0#5029
mergify[bot] merged 4 commits intoreleasefrom
bump/1.126.0

Conversation

@aws-cdk-automation
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation commented Jan 26, 2026

See CHANGELOG

mergify bot and others added 4 commits January 5, 2026 10:13
Exports a new constant `ALL_SPEC_FEATURES` containing all available jsii extension features. This allows consumers of the `@jsii/spec` package to programmatically access the complete list of features without having to maintain their own copy.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license].

[Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
…cript implementation (#5027)

In recent changes, we dropped as many methods from `Jsii$Proxy` as possible. This includes the implementation of `toString()` from `Jsii$Proxy`, which means that `toString()` falls back to the Java implementation instead of the JavaScript one.

```java
@jsii(module = $Module.class, fqn = "aws-cdk-lib.IResolvable")
@Proxy(IResolvable.Jsii$Proxy.class)
public interface IResolvable extends JsiiSerializable {
  List<String> getCreationStack();
  ResolutionTypeHint getTypeHint();
  Object resolve(@NotNull IResolveContext paramIResolveContext);
  
  String toString();   // <---- ⚠️ note this!
  
  public static interface Jsii$Default extends IResolvable {
    @NotNull
    default List<String> getCreationStack() {
       // ... 
    }
    
    @nullable
    default ResolutionTypeHint getTypeHint() {
       // ... 
    }
    
    @NotNull
    default Object resolve(@NotNull IResolveContext context) {
       // ... 
    }

    // <--- ❌ but missing here!
  }
}
```

This doesn't fail because only there is there also a default `toString()` implementation on all objects in Java.

There was no problem when we called `toString()` on a proxy of a public JSII class, but in case we were using a pure interface proxy (when the concrete class was private or even anonymous), we wouldn't forward to the JavaScript-side `toString()` but call the default Java implementation instead.

Fix that and add a test for this behavior.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license].

[Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
@aws-cdk-automation aws-cdk-automation added the pr/no-squash This PR should be merged instead of squash-merging it label Jan 26, 2026
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 26, 2026
@mergify
Copy link
Contributor

mergify bot commented Jan 26, 2026

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Jan 26, 2026
@mergify
Copy link
Contributor

mergify bot commented Jan 26, 2026

Merging (no-squash)...

@mergify mergify bot added the queued label Jan 26, 2026
@mergify mergify bot merged commit 206d44b into release Jan 26, 2026
40 checks passed
@mergify mergify bot deleted the bump/1.126.0 branch January 26, 2026 10:18
@mergify
Copy link
Contributor

mergify bot commented Jan 26, 2026

Merge Queue Status

✅ The pull request has been merged at b6ef2b4

This pull request spent 6 seconds in the queue, with no time running CI.
The checks were run in-place.

Required conditions to merge
  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • status-success=Integration test (jsii-pacmak)
  • status-success=Unit Tests
  • any of [🛡 GitHub branch protection]:
    • check-success = Build
    • check-neutral = Build
    • check-skipped = Build
  • any of [🛡 GitHub branch protection]:
    • check-success = Integration test (jsii-pacmak)
    • check-neutral = Integration test (jsii-pacmak)
    • check-skipped = Integration test (jsii-pacmak)
  • any of [🛡 GitHub branch protection]:
    • check-success = Unit Tests
    • check-neutral = Unit Tests
    • check-skipped = Unit Tests
  • any of [🛡 GitHub repository ruleset rule release no manual]:
    • check-success = Build
    • check-neutral = Build
    • check-skipped = Build
  • any of [🛡 GitHub repository ruleset rule release no manual]:
    • check-success = Integration test (jsii-pacmak)
    • check-neutral = Integration test (jsii-pacmak)
    • check-skipped = Integration test (jsii-pacmak)
  • any of [🛡 GitHub repository ruleset rule release no manual]:
    • check-success = Unit Tests
    • check-neutral = Unit Tests
    • check-skipped = Unit Tests

@mergify mergify bot removed pr/ready-to-merge This PR is ready to be merged. queued labels Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS. pr/no-squash This PR should be merged instead of squash-merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants