Merged
Conversation
Exports a new constant `ALL_SPEC_FEATURES` containing all available jsii extension features. This allows consumers of the `@jsii/spec` package to programmatically access the complete list of features without having to maintain their own copy. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
…cript implementation (#5027) In recent changes, we dropped as many methods from `Jsii$Proxy` as possible. This includes the implementation of `toString()` from `Jsii$Proxy`, which means that `toString()` falls back to the Java implementation instead of the JavaScript one. ```java @jsii(module = $Module.class, fqn = "aws-cdk-lib.IResolvable") @Proxy(IResolvable.Jsii$Proxy.class) public interface IResolvable extends JsiiSerializable { List<String> getCreationStack(); ResolutionTypeHint getTypeHint(); Object resolve(@NotNull IResolveContext paramIResolveContext); String toString(); // <----⚠️ note this! public static interface Jsii$Default extends IResolvable { @NotNull default List<String> getCreationStack() { // ... } @nullable default ResolutionTypeHint getTypeHint() { // ... } @NotNull default Object resolve(@NotNull IResolveContext context) { // ... } // <--- ❌ but missing here! } } ``` This doesn't fail because only there is there also a default `toString()` implementation on all objects in Java. There was no problem when we called `toString()` on a proxy of a public JSII class, but in case we were using a pure interface proxy (when the concrete class was private or even anonymous), we wouldn't forward to the JavaScript-side `toString()` but call the default Java implementation instead. Fix that and add a test for this behavior. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
rix0rrr
approved these changes
Jan 26, 2026
Contributor
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
Contributor
|
Merging (no-squash)... |
Contributor
Merge Queue Status✅ The pull request has been merged at b6ef2b4 This pull request spent 6 seconds in the queue, with no time running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See CHANGELOG