After and after_all_transitions callback execution order #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On the failing tests: Looks like the return value from the I arrived here after a search because I agree with the spirit, but this is probably a breaking-change. |
Member
|
@Ashviniv I think you have a valid point, could you rebase your commit with master branch and resolve conflicts. As this is breaking-change we can release this change in AASM 5.0 |
|
Code Climate has analyzed commit 45b7e94 and detected 0 issues on this pull request. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after transitionshould be called beforeafter_all_transitions, like after event is called before after_all_events.But currently,aftertransition is called afterafter_all_transitions.