Thanks to visit codestin.com
Credit goes to github.com

Skip to content

After and after_all_transitions callback execution order #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ashviniv wants to merge 4 commits into
base: master
Choose a base branch
from
Open

After and after_all_transitions callback execution order #379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e047f95
Fixed 'after_all_transitions' callback after 'after' callback.
Ashviniv Jun 27, 2016
ea6270d
Fixed spec for after and after_all_transition execution order.
Ashviniv Jun 28, 2016
ecd17e4
Updated README.md for after and after_all_transtions execution order.
Ashviniv Jun 28, 2016
45b7e94
Merge branch 'aasm:master' into master
Ashviniv Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,8 +268,8 @@ begin
transition guards
old_state before_exit
old_state exit
after_all_transitions
transition after
after_all_transitions
new_state before_enter
new_state enter
...update state...
Expand Down
2 changes: 1 addition & 1 deletion lib/aasm/core/transition.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ def allowed?(obj, *args)
end

def execute(obj, *args)
invoke_callbacks_compatible_with_guard(event.state_machine.global_callbacks[:after_all_transitions], obj, args)
invoke_callbacks_compatible_with_guard(@after, obj, args)
invoke_callbacks_compatible_with_guard(event.state_machine.global_callbacks[:after_all_transitions], obj, args)
end

def ==(obj)
Expand Down
4 changes: 2 additions & 2 deletions spec/unit/callbacks_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,8 @@
expect(callback).to receive(:exit_open).once.ordered
# expect(callback).to receive(:event_guard).once.ordered.and_return(true)
# expect(callback).to receive(:transition_guard).once.ordered.and_return(true)
expect(callback).to receive(:after_all_transitions).once.ordered
expect(callback).to receive(:after_transition).once.ordered
expect(callback).to receive(:after_all_transitions).once.ordered
expect(callback).to receive(:before_enter_closed).once.ordered
expect(callback).to receive(:enter_closed).once.ordered
expect(callback).to receive(:aasm_write_state).once.ordered.and_return(true) # this is when the state changes
Expand Down Expand Up @@ -111,8 +111,8 @@
expect(callback).to receive(:exit_open).once.ordered
# expect(callback).to receive(:event_guard).once.ordered.and_return(true)
# expect(callback).to receive(:transition_guard).once.ordered.and_return(true)
expect(callback).to receive(:after_all_transitions).once.ordered
expect(callback).to receive(:after_transition).once.ordered
expect(callback).to receive(:after_all_transitions).once.ordered
expect(callback).to receive(:before_enter_closed).once.ordered
expect(callback).to receive(:enter_closed).once.ordered
expect(callback).to receive(:aasm_write_state).once.ordered.and_return(true) # this is when the state changes
Expand Down