Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@FreyJo
Copy link
Member

@FreyJo FreyJo commented Feb 16, 2024

No description provided.

@FreyJo FreyJo requested a review from sandmaennchen February 19, 2024 08:52
@FreyJo FreyJo merged commit adb1244 into acados:master Feb 19, 2024
@FreyJo FreyJo deleted the fix_slack_function_update branch February 19, 2024 09:37
FreyJo added a commit that referenced this pull request Feb 20, 2024
…1040)

In some places `tmp_ux` and `ux` where used in a mixed way, i.e.
`compute_fun` of constraint modules and what was fixed in #1039
- fixes bug when using globalization and cost computation
- fixes bug in globalization with slacks. Constraint was evaluated with
slack values from SQP iterate instead of values from the line search
candidate

Implementation:
- Removed all `tmp_*` pointers in SQP submodules
- Always evaluate at `ux`
- When one wants to evaluate at another iterate, these pointers have to
be temporarily set to another iterate and afterwards reset to the
nominal SQP iterate, as done in `ocp_nlp_evaluate_merit_fun` now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant