-
Notifications
You must be signed in to change notification settings - Fork 302
Batch integrator and OCP solver for parallel solves #1087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
896fea9 to
efb90f8
Compare
FreyJo
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! ⚡
Merged
FreyJo
pushed a commit
that referenced
this pull request
Apr 30, 2024
Apparently, shared libraries with and without openmp cannot easily be combined. If the acados batch solvers introduced in #1087 should be used, it is thus recommended to compile the acados shared library with openmp and set the number of threads to 1. This problem seems to be related to: * JuliaLang/julia#10938 * casadi/casadi#2447 This PR implements corresponding warnings in `AcadosOcpBatchSolver` and `AcadosSimBatchSolver` and removes the examples from the tests (as we do not want to compile acados with openmp for all tests).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a parallelizable batch solve for integrators and OCP solvers. The batch solve is interfaced from python with
AcadosOcpBatchSolverandAcadosSimBatchSolver. These classes holdN_batchidentical solvers and provide a parallelizable solve function. All other operations have to be called individually for each of the solvers via their standard interface.Parallelization via openmp can be switched on by setting
num_threads_in_batch_solvewhich has been added to the solver options.